Fix ge2/1 demonstrator in validation - backport

[watson-ij]

PR description:

Backport of PR #36835, this only includes the changes to the Validation/MuonGEMHits code to create the histograms correctly when the demonstrator GEM is included as PR #36870 should contain the code necessary for the geometry builder.

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

If the demonstrator geometry will be used in 12_2 as #36870 indicates this will be necessary to avoid crashes.

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[cmsbuild]

A new Pull Request was created by @watson-ij (Ian J. Watson) for CMSSW_12_2_X.

It involves the following packages:

• Validation/MuonGEMHits (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@jshlee this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f0eb8f/22184/summary.html
COMMIT: 7d530b7
CMSSW: CMSSW_12_2_X_2022-02-02-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36872/22184/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3250594
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3250566
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 41 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[rvenditti]

Hi @watson-ij, we noticed that in your previous PR #36835, 2 ME have been added in wf 11634.911, while this PR does not add any new ME for each tested wf. Is this expected?

[perrotta]

Hi @watson-ij, we noticed that in your previous PR #36835, 2 ME have been added in wf 11634.911, while this PR does not add any new ME for each tested wf. Is this expected?

As written in the description, the demonstrator GEM is only backported with the sibling PR 36870: can this answer your question @rvenditti ?
In the github thread of that PR you can find the resulrs of the tests launched with the whole set of PR to be backported to update the Run3 geometry.

[rvenditti]

Hi @watson-ij, we noticed that in your previous PR #36835, 2 ME have been added in wf 11634.911, while this PR does not add any new ME for each tested wf. Is this expected?

As written in the description, the demonstrator GEM is only backported with the sibling PR 36870: can this answer your question @rvenditti ? In the github thread of that PR you can find the resulrs of the tests launched with the whole set of PR to be backported to update the Run3 geometry.

Hi @perrotta thank you for the clarification, I checked PR#36870 and found the two mentioned MEs, so everything looks like as expected.

[rvenditti]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• This fix is designed to cope with the new Run3 geometry, but it does not strictly depends on it: it can therefore get merged in 12_2 independently from the other PRs meant to implement the new geometry.