Clean unused dependencies from BuildFiles

[guitargeek]

PR description:

Another quick BuildFile cleaning PR in the style of many before (for example #36144).

In many cases, the dependencies had to be moved to the appropriate BuildFile, for example from a plugins directory to the library directory or vice versa.

In one place, a missing include has been added to not cause a false positive in my BuildFile checker.

This PR cleans unnecessary includes from CMSSW BuildFiles that were added in the last months.

PR validation:

CMSSW compiles.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport intended.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36834/28015

• This PR adds an extra 44KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/SiPixelPhase1Heterogeneous/plugins/BuildFile.xml modified in PR(s): Two DQM analyzer for Pixel Digi and Clusters produced by either GPU or CPU #36749

[cmsbuild]

A new Pull Request was created by @guitargeek (Jonas Rembser) for master.

It involves the following packages:

• CalibTracker/SiPixelESProducers (alca)
• CondTools/JetMET (db)
• DQM/DTMonitorModule (dqm)
• DQM/GEM (dqm)
• DQM/SiPixelPhase1Heterogeneous (dqm)
• DQMOffline/L1Trigger (dqm, l1)
• DQMOffline/Muon (dqm)
• DQMOffline/MuonDPG (dqm)
• JetMETCorrections/Modules (reconstruction)
• PhysicsTools/HepMCCandAlgos (analysis)
• PhysicsTools/SelectorUtils (reconstruction)
• RecoEgamma/EgammaElectronAlgos (reconstruction)
• RecoEgamma/ElectronIdentification (reconstruction)
• RecoEgamma/PhotonIdentification (reconstruction)
• RecoHGCal/TICL (upgrade, reconstruction)
• RecoLocalTracker/SiPhase2VectorHitBuilder (upgrade, reconstruction)
• RecoMuon/MuonIdentification (reconstruction)
• RecoMuon/MuonRechitClusterProducer (reconstruction)
• RecoTracker/NuclearSeedGenerator (reconstruction)
• SimTracker/TrackAssociation (simulation)
• SimTracker/VertexAssociation (simulation)

@rekovic, @jpata, @santocch, @cecilecaillol, @civanch, @yuanchao, @ahmad3213, @cmsbuild, @pmandrik, @epalencia, @emanueleusai, @mdhildreth, @AdrianoDee, @jfernan2, @slava77, @ggovi, @pbo0, @francescobrivio, @malbouis, @clacaputo, @srimanob, @rvenditti, @tvami can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @felicepantaleo, @jainshilpi, @schoef, @CeliaFernandez, @OzAmram, @fioriNTU, @lgray, @abbiendi, @mmusich, @seemasharmafnal, @sobhatta, @mmarionncern, @hdelanno, @battibass, @ahinzmann, @threus, @JanFSchulte, @jhgoh, @varuns23, @apsallid, @sscruz, @cericeci, @ferencek, @trocino, @rociovilar, @Sam-Harper, @barvic, @HuguesBrun, @GiacomoSguazzoni, @tocheng, @VinInn, @jdamgov, @bellan, @nhanvtran, @gkasieczka, @rovere, @jandrea, @idebruyn, @ebrondol, @ptcox, @mtosi, @dgulhan, @clelange, @watson-ij, @jdolen, @Fedespring, @calderona, @hatakeyamak, @dkotlins, @lecriste, @afiqaize, @gpetruc, @wrtabb, @mariadalfonso, @tvami, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-122f05/22078/summary.html
COMMIT: 8177012
CMSSW: CMSSW_12_3_X_2022-01-29-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36834/22078/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3449612
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3449584
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[srimanob]

+Upgrade

Technical PR, no change is expected. PR test runs fine.

[smuzaffar]

comparison differences are expected for ubsan, so please ignore those. Ubsan tests are mostly to make sure that ubsan can build without link errors. #36834 (comment) looks good for build part to all looks good with this cleanup

[francescobrivio]

+1

• trivial changes on the alca/db side
• successful compilation for UBSAN build (see Clean unused dependencies from BuildFiles #36834 (comment) and Clean unused dependencies from BuildFiles #36834 (comment))
• no differences/failures observed for standrd CMSSW compilation (see Clean unused dependencies from BuildFiles #36834 (comment))

[civanch]

+1

[guitargeek]

Hi @clacaputo, I hope Shazad's comment cleared your doubt. Can you please approve?

[guitargeek]

Hi @santocch, can you please take a look and approve? And @perrotta, this PR can also be merged without the analysis signoff as this is usually the slowest to get.

[perrotta]

Hi @santocch, can you please take a look and approve? And @perrotta, this PR can also be merged without the analysis signoff as this is usually the slowest to get.

@guitargeek we normally bypass analysis signature, but this PR still misses the @cms-sw/reconstruction-l2 one...

[clacaputo]

+reconstruction

• technical PR
• RECO changes found in the test are related to UBSAN build and can be ignored Clean unused dependencies from BuildFiles #36834 (comment)

[perrotta]

+1

[perrotta]

merge

[santocch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.