-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove deprecation warnings from FastSimulation/Track*
#36825
remove deprecation warnings from FastSimulation/Track*
#36825
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36825/27987
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @sbein can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-63edca/22057/summary.html Comparison SummarySummary:
|
@cms-sw/fastsim-l2 any comment on this PR? |
@sbein , please, comment |
@cms-sw/orp-l2 this simple PR has stayed idle with no sign of review for 13 days now. |
FastSimulation/TrackerSetup/plugins/TrackerInteractionGeometryESProducer.cc
Outdated
Show resolved
Hide resolved
FastSimulation/TrackerSetup/plugins/TrackerInteractionGeometryESProducer.cc
Outdated
Show resolved
Hide resolved
FastSimulation/TrackerSetup/plugins/TrackerInteractionGeometryESProducer.cc
Outdated
Show resolved
Hide resolved
FastSimulation/TrackerSetup/plugins/TrackerInteractionGeometryESProducer.cc
Outdated
Show resolved
Hide resolved
2ff6dec
to
bdc9f37
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36825/28254
|
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-63edca/22337/summary.html Comparison SummarySummary:
|
i will check in the next hour |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Part of the migration in #31061.
Went systematically through all of the
CMSDEPRECATED_X
warnings in theFastSimulation/Track*
subsystem fromCMSSW_12_3_CMSDEPRECATED_X_2022-01-21-2300
and removed all deprecatedEventSetup
API calls.PR validation:
cmssw
compilesif this PR is a backport please specify the original PR and why you need to backport that PR:
N/A