Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex115 Tune CaloGeometryBuilder for changing configuration #36814

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Run3-gex115 Tune CaloGeometryBuilder for changing configuration #36814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions Geometry/CaloEventSetup/python/CaloGeometryBuilderPhaseII_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
import FWCore.ParameterSet.Config as cms

CaloGeometryBuilder = cms.ESProducer("CaloGeometryBuilder",
SelectedCalos = cms.vstring('HCAL' ,
'ZDC' ,
'CASTOR' ,
'EcalBarrel' ,
'TOWER' )
SelectedCalos = cms.vstring('HCAL' ,
'ZDC' ,
'EcalBarrel' ,
'TOWER' ,
'HGCalEESensitive' ,
'HGCalHESiliconSensitive' ,
'HGCalHEScintillatorSensitive')
)


8 changes: 8 additions & 0 deletions Geometry/CaloEventSetup/python/CaloGeometryBuilder_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,12 @@
'TOWER' )
)

from Configuration.Eras.Modifier_run3_common_cff import run3_common
run3_common.toModify(CaloGeometryBuilder,
SelectedCalos = ['HCAL', 'ZDC', 'EcalBarrel', 'EcalEndcap', 'EcalPreshower', 'TOWER']
)

from Configuration.Eras.Modifier_phase2_common_cff import phase2_common
phase2_common.toModify(CaloGeometryBuilder,
SelectedCalos = ['HCAL', 'ZDC', 'EcalBarrel', 'TOWER', 'HGCalEESensitive', 'HGCalHESiliconSensitive', 'HGCalHEScintillatorSensitive']
)
Copy link
Contributor

@srimanob srimanob Jan 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand the change related to Phase-2. Could you please clarify?

The CaloGeometryPhaseII_cff.py calls CaloGeometryBuilderPhaseII_cfi where the change is applied. However, this PR also introduce Phase-2 modifier which seems to do the same. But who will call this? Or should we change the way to call, e.g. call CaloGeometryBuilder_cfi.py directly, so that we can remove CaloGeometryPhaseII_cff.py ?