Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 12_3_X #36807

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

missirol
Copy link
Contributor

PR description:

Development of HLT menus for CMSSW_12_3_X. Includes the integration of the following JIRA tickets:

  • CMSHLT-2184: [BTV] addition of paths with DeepJet b-tagger
  • CMSHLT-2218: [BTV] fix to MC_CaloBTagDeepCSV path

A customisation function is added to make these latest menus, built in 12_3_0_pre4, work in the latest IBs. This customisation is needed after the integration of #36639, which updated, wrt 12_3_0_pre4, the cfi template of a producer now used in the latest GRun menu.

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36807/27964

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

A customisation function is added to make these latest menus, built in 12_3_0_pre4, work in the latest IBs. This customisation is needed after the integration of #36639, which updated, wrt 12_3_0_pre4, the cfi template of a producer now used in the latest GRun menu.

@ahinzmann , could you please confirm that

(PFCandidatePrimaryVertexSorter).assignment.NumOfPUVtxsForCharged = cms.int32(-1) in 12_3_0_pre4

is equivalent to

(PFCandidatePrimaryVertexSorter).assignment.NumOfPUVtxsForCharged = cms.uint32(0) after #36639?

Thanks!

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf3160/22023/summary.html
COMMIT: 7542174
CMSSW: CMSSW_12_3_X_2022-01-26-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36807/22023/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3449318
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 14
  • DQMHistoTests: Total successes: 3449271
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 156.968 KiB( 42 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 21.908 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 11634.0,... ): 4.254 KiB HLT/Filters
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: found differences in 4 / 42 workflows

@missirol
Copy link
Contributor Author

+hlt

  • HLT-development PR needed to introduce a customisation function which makes the latest HLT menus in ConfDB functional not only for 12_3_0_pre4, but also for the 12_3_X branch (master)
  • changes in outputs of Run-3 wfs are in line with expectations for these HLT updates
  • #36807 (comment) is taken as a 'yes', based on my understanding of the changes in #36639

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jan 27, 2022

+1

@cmsbuild cmsbuild merged commit 56471ef into cms-sw:master Jan 27, 2022
@missirol missirol deleted the HLTdevelopment123X branch January 27, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants