ECAL : correction of a minor bug in a Ecal laser tool #36768

depasse · 2022-01-21T10:42:43Z

PR description:

In Ecal, this tool trasforms a transparency laser ASCII file (created in the laser farm) in a DB sqlite one.

PR validation:

The pgm failed before, in a given configuration. Now it perfectly works. Test done with different input files.

…CII file in DB sqlite one

cmsbuild · 2022-01-21T10:50:36Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36768/27903

This PR adds an extra 16KB to repository

cmsbuild · 2022-01-21T10:50:57Z

A new Pull Request was created by @depasse for master.

It involves the following packages:

CalibCalorimetry/EcalTrivialCondModules (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@rchatter, @tocheng, @argiro, @thomreis, @simonepigazzini, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

tvami · 2022-01-21T21:58:41Z

CalibCalorimetry/EcalTrivialCondModules/src/EcalLaserCondTools.cc

@@ -326,7 +326,7 @@ void EcalLaserCondTools::fillDb(CorrReader& r) {
      if (iIov <= skipIov_) {
        std::cout << "Skipping IOV " << iIov << "\n";
        continue;
-      } else if (processedIovs >= nIovs_) {
+      } else if (processedIovs >= nIovs_ && nIovs_ >= 0) {
        std::cout << "Requested number of IOVs, " << nIovs_ << ", processed.\n";


Suggested change

std::cout << "Requested number of IOVs, " << nIovs_ << ", processed.\n";

edm::LogPrint("EcalLaserCondTools") << "Requested number of IOVs, " << nIovs_ << ", processed.\n";

tvami · 2022-01-21T21:58:57Z

CalibCalorimetry/EcalTrivialCondModules/src/EcalLaserCondTools.cc

@@ -326,7 +326,7 @@ void EcalLaserCondTools::fillDb(CorrReader& r) {
      if (iIov <= skipIov_) {
        std::cout << "Skipping IOV " << iIov << "\n";


Suggested change

std::cout << "Skipping IOV " << iIov << "\n";

edm::LogPrint("EcalLaserCondTools") << "Skipping IOV " << iIov << "\n";

tvami · 2022-01-21T21:59:24Z

type bug-fix

…CII file in DB sqlite one

cmsbuild · 2022-01-22T09:31:18Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36768/27920

This PR adds an extra 16KB to repository

cmsbuild · 2022-01-22T09:31:42Z

Pull request #36768 was updated. @cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

tvami · 2022-01-22T12:40:24Z

@cmsbuild , please test

cmsbuild · 2022-01-22T16:17:13Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5c7fe/21923/summary.html
COMMIT: 7205c4c
CMSSW: CMSSW_12_3_X_2022-01-21-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36768/21923/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 43
DQMHistoTests: Total histograms compared: 3465668
DQMHistoTests: Total failures: 5
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3465640
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 42 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 181 log files, 42 edm output root files, 43 DQM output files
TriggerResults: no differences found

tvami · 2022-01-22T16:32:53Z

+alca

cmsbuild · 2022-01-22T16:33:14Z

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2022-01-26T11:31:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36768/27962

This PR adds an extra 20KB to repository

cmsbuild · 2022-01-26T11:31:25Z

Pull request #36768 was updated. @cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

perrotta · 2022-01-26T13:00:13Z

please test

cmsbuild · 2022-01-26T16:46:25Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5c7fe/22021/summary.html
COMMIT: d272015
CMSSW: CMSSW_12_3_X_2022-01-26-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36768/22021/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 43
DQMHistoTests: Total histograms compared: 3449324
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3449296
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
Checked 181 log files, 42 edm output root files, 43 DQM output files
TriggerResults: no differences found

tvami · 2022-01-26T17:40:52Z

I see this in the Jenkins test, but I dont think it's connected to this PR

tvami · 2022-01-26T17:41:09Z

+alca

cmsbuild · 2022-01-26T17:41:16Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2022-01-26T18:08:17Z

I see this in the Jenkins test, but I dont think it's connected to this PR

No. The fix is already merged, and the warning will hopefully disappear after the next IB

perrotta · 2022-01-26T18:09:48Z

+1

perrotta · 2022-01-26T18:15:31Z

Sorry, I removed the previous comment (that was intended for another PR instead): no backport is requested for this PR

ECAL : correction of a minor bug in a Ecal laser tool to transform AS…

db5750f

…CII file in DB sqlite one

cmsbuild added this to the CMSSW_12_3_X milestone Jan 21, 2022

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Jan 21, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 21, 2022

tvami reviewed Jan 21, 2022

View reviewed changes

cmsbuild added the bug-fix label Jan 21, 2022

ECAL : correction of a minor bug in a Ecal laser tool to transform AS…

7205c4c

…CII file in DB sqlite one

cmsbuild added code-checks-pending and removed code-checks-approved labels Jan 22, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 22, 2022

cmsbuild added tests-started and removed tests-pending labels Jan 22, 2022

cmsbuild added tests-rejected and removed tests-started labels Jan 22, 2022

cmsbuild added alca-pending code-checks-pending pending-signatures tests-pending and removed code-checks-approved labels Jan 26, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 26, 2022

cmsbuild added tests-started and removed tests-pending labels Jan 26, 2022

cmsbuild added tests-approved and removed tests-started labels Jan 26, 2022

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Jan 26, 2022

cmsbuild added orp-approved and removed orp-pending labels Jan 26, 2022

cmsbuild merged commit 990b7fc into cms-sw:master Jan 26, 2022

cmsbuild mentioned this pull request Jan 31, 2022

[Aarch64] Build with -march=armv8-a cms-sw/cmsdist#7593

Closed

depasse deleted the bugEcalLaserTools branch November 9, 2023 14:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ECAL : correction of a minor bug in a Ecal laser tool #36768

ECAL : correction of a minor bug in a Ecal laser tool #36768

depasse commented Jan 21, 2022

cmsbuild commented Jan 21, 2022

cmsbuild commented Jan 21, 2022

tvami Jan 21, 2022

tvami Jan 21, 2022

tvami commented Jan 21, 2022

cmsbuild commented Jan 22, 2022

cmsbuild commented Jan 22, 2022

tvami commented Jan 22, 2022

cmsbuild commented Jan 22, 2022

tvami commented Jan 22, 2022

cmsbuild commented Jan 22, 2022

cmsbuild commented Jan 26, 2022

cmsbuild commented Jan 26, 2022

perrotta commented Jan 26, 2022

cmsbuild commented Jan 26, 2022

tvami commented Jan 26, 2022

tvami commented Jan 26, 2022

cmsbuild commented Jan 26, 2022

perrotta commented Jan 26, 2022

perrotta commented Jan 26, 2022 •

edited

Loading

perrotta commented Jan 26, 2022

	std::cout << "Requested number of IOVs, " << nIovs_ << ", processed.\n";
	edm::LogPrint("EcalLaserCondTools") << "Requested number of IOVs, " << nIovs_ << ", processed.\n";

		@@ -326,7 +326,7 @@ void EcalLaserCondTools::fillDb(CorrReader& r) {
		if (iIov <= skipIov_) {
		std::cout << "Skipping IOV " << iIov << "\n";

ECAL : correction of a minor bug in a Ecal laser tool #36768

ECAL : correction of a minor bug in a Ecal laser tool #36768

Conversation

depasse commented Jan 21, 2022

PR description:

PR validation:

cmsbuild commented Jan 21, 2022

cmsbuild commented Jan 21, 2022

tvami Jan 21, 2022

Choose a reason for hiding this comment

tvami Jan 21, 2022

Choose a reason for hiding this comment

tvami commented Jan 21, 2022

cmsbuild commented Jan 22, 2022

cmsbuild commented Jan 22, 2022

tvami commented Jan 22, 2022

cmsbuild commented Jan 22, 2022

RelVals-INPUT

Comparison Summary

tvami commented Jan 22, 2022

cmsbuild commented Jan 22, 2022

cmsbuild commented Jan 26, 2022

cmsbuild commented Jan 26, 2022

perrotta commented Jan 26, 2022

cmsbuild commented Jan 26, 2022

Comparison Summary

tvami commented Jan 26, 2022

tvami commented Jan 26, 2022

cmsbuild commented Jan 26, 2022

perrotta commented Jan 26, 2022

perrotta commented Jan 26, 2022 • edited Loading

perrotta commented Jan 26, 2022

perrotta commented Jan 26, 2022 •

edited

Loading