Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_2_X] Include PF HLT Calibration and new EGM Regression in mcRun3 and mcRun4 GTs #36719

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

francescobrivio
Copy link
Contributor

PR description:

Backport of #36710.
Adds to the MC Run3 and Run4 GTs:

The PF tag is:
PFCalibration_120X_mcRun3_2021_hlt

For EGM the 24 tags are:
electron_eb_ecalTrk_1To500_0p2To2_mean_Run3_120X_V1
electron_ee_ecalTrk_1To500_0p2To2_mean_Run3_120X_V1
electron_eb_ecalTrk_1To500_0p0002To0p5_sigma_Run3_120X_V1
electron_ee_ecalTrk_1To500_0p0002To0p5_sigma_Run3_120X_V1
photon_eb_ecalOnly_5To500_0p2To2_mean_Run3_120X_V1
photon_ee_ecalOnly_5To500_0p2To2_mean_Run3_120X_V1
photon_eb_ecalOnly_5To500_0p0002To0p5_sigma_Run3_120X_V1
photon_ee_ecalOnly_5To500_0p0002To0p5_sigma_Run3_120X_V1
electron_eb_ecalOnly_1To500_0p2To2_mean_Run3_120X_V1
electron_ee_ecalOnly_1To500_0p2To2_mean_Run3_120X_V1
electron_eb_ecalOnly_1To500_0p0002To0p5_sigma_Run3_120X_V1
electron_ee_ecalOnly_1To500_0p0002To0p5_sigma_Run3_120X_V1
pfscecal_EBCorrection_offline_v2_Run3_120X_V1
pfscecal_EECorrection_offline_v2_Run3_120X_V1
pfscecal_EBUncertainty_offline_v2_Run3_120X_V1
pfscecal_EEUncertainty_offline_v2_Run3_120X_V1
GEDelectron_EBCorrection_120X_EGM_v1
GEDelectron_EBUncertainty_120X_EGM_v1
GEDelectron_EECorrection_120X_EGM_v1
GEDelectron_EEUncertainty_120X_EGM_v1
GEDphoton_EBCorrection_120X_EGM_v1
GEDphoton_EBUncertainty_120X_EGM_v1
GEDphoton_EECorrection_120X_EGM_v1
GEDphoton_EEUncertainty_120X_EGM_v1

The difference in GTs is here:
2021 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/122X_mcRun3_2021_design_v5/122X_mcRun3_2021_design_v6

2021 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/122X_mcRun3_2021_realistic_v5/122X_mcRun3_2021_realistic_v6

2021 cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/122X_mcRun3_2021cosmics_realistic_deco_v5/122X_mcRun3_2021cosmics_realistic_deco_v6

2021 heavy ion
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/122X_mcRun3_2021_realistic_HI_v5/122X_mcRun3_2021_realistic_HI_v6

2023 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/122X_mcRun3_2023_realistic_v5/122X_mcRun3_2023_realistic_v6

2024 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/122X_mcRun3_2024_realistic_v5/122X_mcRun3_2024_realistic_v6

Phase 2 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/122X_mcRun4_realistic_v4/122X_mcRun4_realistic_v5

PR validation:

Validated with:

  • runTheMatrix.py -l 12034.0,7.23,12834.0 --ibeos -j 15
  • runTheMatrix.py --what upgrade -l 34606.0 --command='--conditions auto:phase2_realistic' (for PhaseII GT)

Backport:

Backport of #36710

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @francescobrivio for CMSSW_12_2_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

test parameters:

  • workflows=12034.0,7.23,12834.0

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f28f42/21746/summary.html
COMMIT: fc41ffa
CMSSW: CMSSW_12_2_X_2022-01-16-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36719/21746/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f28f42/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-f28f42/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11709 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250623
  • DQMHistoTests: Total failures: 10846
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3239754
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: found differences in 5 / 41 workflows

@malbouis
Copy link
Contributor

+alca

  • failures are only in MC Run3 and Run4 workflows on quantities that indicate the change introduced in the GTs.
  • The only workflow that is not related to mc run3 and Run4 has only MessageLogger failures.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

  • Updated GT in autoCond

@cmsbuild cmsbuild merged commit 2211742 into cms-sw:CMSSW_12_2_X Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants