-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[12.2.X] Further optimization of the SiPixel LA PCL workflow #36711
[12.2.X] Further optimization of the SiPixel LA PCL workflow #36711
Conversation
…ed in the dqmBeginRun method
…pushfile to dqmBeginRun
…ange logic to write out to DB to take into account number of hits
type bug-fix |
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_2_X. It involves the following packages:
@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
test parameters:
|
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e32317/21728/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
+alca |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
backport of #36565 |
backport of #36538 |
+1 |
backport of #36565 and #36538
PR description:
Miscellanea updates and bug-fixes to the SiPixel LA PCL workflow that are built on top of the replay at dmwm/T0#4635.
SiPixelTemplate::pushfile
indqmBeginRun
instead of theanalyze
method;put
s, seeCondFormats
: fix warning message about "skipping this put" #36535);SiPixelTemplate
object in memory on demand in the case in which the moduleSiPixelLorentzAnglePCLWorker
is not run in PCL mode (notInPCL_ = True
) and by reducing the number of bins of the 2D drift vs depth maps.std::endl
at the end of LogMessages is removed as requested at Several updates to SiPixel LA PCL workflow #36538 (comment) in commit 0cfb6bfPR validation:
Privately run:
cmsDriver.py testReAlCa -s ALCA:PromptCalibProdSiPixelLorentzAngle --conditions 121X_dataRun3_Express_TIER0_REPLAY_Run2_v1 --scenario pp --data --era Run2_2018 --datatier ALCARECO --eventcontent ALCARECO --processName=ReAlCa -n 100000 --dasquery='file dataset=/StreamExpress/Tier0_REPLAY_2021-SiPixelCalSingleMuon-Express-v1/ALCARECO' --customise_commands='process.ALCARECOCalSignleMuonFilterForSiPixelLorentzAngle.TriggerResultsTag = cms.InputTag ( "TriggerResults","","HLT" ) ; process.ALCARECOCalSignleMuonFilterForSiPixelLorentzAngle.HLTPaths = ["*"]' --nThreads=4
followed by:
cmsDriver.py stepHarvest -s ALCAHARVEST:SiPixelLA --conditions 121X_dataRun3_Express_TIER0_REPLAY_Run2_v1 --scenario pp --data --era Run2_2018 --filein file:PromptCalibProdSiPixelLorentzAngle.root -n -1
Profiling the RSS vs time of the job containing the
ALCA:PromptCalibProdSiPixelLorentzAngle
(run on 4 threads and 4 stream) on 100k events shows a reduction of about 40% in RSS memory and of 20 times in computing wall-clock time.if this PR is a backport please specify the original PR and why you need to backport that PR:
This is a combined backport of PRs #36565 and #36538 to CMSSW_12_2_X as agreed at #36538 (comment) in order to perform a new Tier-0 replay.