Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.2.X] Further optimization of the SiPixel LA PCL workflow #36711

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jan 14, 2022

backport of #36565 and #36538

PR description:

Miscellanea updates and bug-fixes to the SiPixel LA PCL workflow that are built on top of the replay at dmwm/T0#4635.

  • made the processing much faster by calling SiPixelTemplate::pushfile in dqmBeginRun instead of the analyze method;
  • add basic accepted tracks monitoring;
  • adding plot titles;
  • re-organize folders to have subfolders: (Top) / (BPix) / etc. ..;
  • actually do write to DB the values for the "new" modules when they are fit;
  • change the default cut value on the fit probability for writing out the payload from 0.5 to 0.1;
  • fix a bug that was causing populating the lists of "new" modules and modules attached to a given "sector" multiple times (this was triggering several warnings in the harvesting step when populating the DB about multiple puts, see CondFormats: fix warning message about "skipping this put" #36535);
  • further memory footprint reduction is achieved in commit 69b9256 by loading the SiPixelTemplate object in memory on demand in the case in which the module SiPixelLorentzAnglePCLWorker is not run in PCL mode (notInPCL_ = True) and by reducing the number of bins of the 2D drift vs depth maps.
  • for Run2 replays the list of "new" modules is different. That is dealt with via era modifiers;
  • a bug that was messing up the computation of the value of the Lorentz Angle for the "new" modules is addressed;
  • monitoring of the input number of clusters and output Lorentz Angle (and fit chi2/ndf) is introduced;
  • std::endl at the end of LogMessages is removed as requested at Several updates to SiPixel LA PCL workflow #36538 (comment) in commit 0cfb6bf
  • some documentation is added;

PR validation:

Privately run:

 cmsDriver.py testReAlCa -s ALCA:PromptCalibProdSiPixelLorentzAngle --conditions 121X_dataRun3_Express_TIER0_REPLAY_Run2_v1 --scenario pp --data --era Run2_2018 --datatier ALCARECO --eventcontent ALCARECO --processName=ReAlCa -n 100000 --dasquery='file dataset=/StreamExpress/Tier0_REPLAY_2021-SiPixelCalSingleMuon-Express-v1/ALCARECO' --customise_commands='process.ALCARECOCalSignleMuonFilterForSiPixelLorentzAngle.TriggerResultsTag = cms.InputTag ( "TriggerResults","","HLT" ) ; process.ALCARECOCalSignleMuonFilterForSiPixelLorentzAngle.HLTPaths = ["*"]' --nThreads=4 

followed by:

 cmsDriver.py stepHarvest -s ALCAHARVEST:SiPixelLA --conditions 121X_dataRun3_Express_TIER0_REPLAY_Run2_v1 --scenario pp --data --era Run2_2018 --filein file:PromptCalibProdSiPixelLorentzAngle.root -n -1

Profiling the RSS vs time of the job containing the ALCA:PromptCalibProdSiPixelLorentzAngle (run on 4 threads and 4 stream) on 100k events shows a reduction of about 40% in RSS memory and of 20 times in computing wall-clock time.

memory_PR_12_2_X

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a combined backport of PRs #36565 and #36538 to CMSSW_12_2_X as agreed at #36538 (comment) in order to perform a new Tier-0 replay.

@mmusich
Copy link
Contributor Author

mmusich commented Jan 14, 2022

type bug-fix

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 14, 2022

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_2_X.

It involves the following packages:

  • CalibTracker/SiPixelLorentzAngle (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@tocheng, @OzAmram, @ferencek, @mmusich, @dkotlins, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jan 14, 2022

test parameters:

  • workflow = 1001.2

@mmusich
Copy link
Contributor Author

mmusich commented Jan 14, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e32317/21728/summary.html
COMMIT: fb67ef3
CMSSW: CMSSW_12_2_X_2022-01-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36711/21728/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e32317/1001.2_RunZeroBias2017F+RunZeroBias2017F+TIER0EXPRUN2+ALCAEXPRUN2+ALCAHARVDSIPIXELCAL+ALCAHARVDSIPIXELCALLA

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250486
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3250457
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -3264.155 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 1001.0 ): -3264.806 KiB AlCaReco/SiPixelLorentzAngle
  • DQMHistoSizes: changed ( 1001.0 ): 0.650 KiB AlCaReco/SiPixelLorentzAngleHarvesting
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jan 16, 2022

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@tvami
Copy link
Contributor

tvami commented Jan 16, 2022

backport of #36565

@tvami
Copy link
Contributor

tvami commented Jan 16, 2022

backport of #36538

@qliphy
Copy link
Contributor

qliphy commented Jan 17, 2022

+1

@cmsbuild cmsbuild merged commit c74088b into cms-sw:CMSSW_12_2_X Jan 17, 2022
@mmusich mmusich deleted the furtherOptSiPixelLorentzAnglePCLWorker_12_2_X branch January 17, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants