Run3 gex108 Modify all Run3 geometry scenarios by including demonstration chambers of GE21 & RPC, and detectors in forward region (BHM, PLT, BCMF) plus removing BSC

[bsunanda]

PR description:

Modify all Run3 geometry scenarios by including demonstration chambers of GE21 & RPC, and detectors in forward region (BHM, PLT, BCMF) plus removing BSC

PR validation:

Use the runTheMatrix test workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

If successful, it needs to be back ported to 12_2_X

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36585/27547

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Configuration/Geometry (geometry, upgrade)
• Geometry/CMSCommonData (geometry, upgrade)
• Geometry/ForwardCommonData (geometry)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@vargasa, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-55b3da/21460/summary.html
COMMIT: 762d9af
CMSSW: CMSSW_12_3_X_2021-12-23-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36585/21460/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 11634.911

----- Begin Fatal Exception 23-Dec-2021 22:52:54 CET-----------------------
An exception of category 'InvalidDetId' occurred while
   [0] Processing global begin Run run: 1
   [1] Prefetching for module L1TMuonOverlapPhase1TrackProducer/'simOmtfDigis'
   [2] Calling method for EventSetup module RPCGeometryESModule/''
Exception Message:
RPCDetId ctor: det: 0 subdet: 0 is not a valid RPC id
----- End Fatal Exception -------------------------------------------------

[civanch]

@bsunanda , I would indeed propose to add to g4SimHits two new Boolean parameters to RPS and GEM SD, which will disable hits in demonstrator chambers by default. Corresponding additions are needed also in SD classes. Doing this, we will be able to establish Run-3 geometry before all problems of demonstrator hits will be resolved. Also it may be useful for production do not have these hits.

[bsunanda]

@civanch Thanks Vladimir; I am working on this

[bsunanda]

@civanch @watson-ij I still get failure in GEMStripDigiValidation for accessing GEM geometry parameters. I think Ian was looking into this updating the GEMGeometry builder. Can he point me to the PR which he had and if it is integrated with the master

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36585/27636

• This PR adds an extra 60KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36585/27636/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36585/27636/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36585/27638

• This PR adds an extra 64KB to repository

[cmsbuild]

Pull request #36585 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again.

[bsunanda]

This PR is broken into 3 parts: #36652, #36653 and #36654. The first 2 PR's are ready to be merged first. The 3rd PR has to wait when these 2 PR's and the ones from GEM group are merged.