-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-gex104 Modify xml files for plt, bcmf to be included for run3 scenario and test how removal of bsc detector from the scenario can be made effective #36564
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36564/27508
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebbe09/21418/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@bsunanda could you please make both the title and the PR description more self-explanatory? |
+1 |
PR description:
Check possibility of adding plt, bcmf and remove bsc detector for run3 scenario. PLT, BCM, BHM detectors should be a part of the Run3 scenario and BSC has been decommissioned after Run1. The RUn3 scenario needs changes. The xml files for PLT, BCM need some changes to be included in the Run3 scenario. Before modifying the Run3 scenario, the changes needed in these XML files are tested with overlap checks. These changes along with the demonstration chambers for GE21 and RPC will be included in the new Run3 geometry description.
PR validation:
Checked with the overlap checking tool within Geometry/MuonCommonData/test/python
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special. Once integrated will redefine Run3 geometry