Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit # events to process in 0T PU workflows to avoid exploding in tracking time #36503

Closed
wants to merge 1 commit into from

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Dec 15, 2021

PR description:

In response to #36492. Title says it all.

PR validation:

$ runTheMatrix.py -nel 11834.24
11834.24 2021PU_0T+TTbar_14TeV_TuneCP5_GenSim+DigiPU+RecoNanoPU+HARVESTNanoPU [1]: cmsDriver.py TTbar_14TeV_TuneCP5_cfi  -s GEN,SIM -n 1 --conditions auto:phase1_2021_realistic_0T --beamspot Run3RoundOptics25ns13TeVLowSigmaZ --datatier GEN-SIM --eventcontent FEVTDEBUG --geometry DB:Extended --era Run3 --magField 0T --relval 9000,100 
                                           [2]: cmsDriver.py step2  -s DIGI:pdigi_valid,L1,DIGI2RAW,HLT:@relval2021 --conditions auto:phase1_2021_realistic_0T --datatier GEN-SIM-DIGI-RAW -n 1 --eventcontent FEVTDEBUGHLT --geometry DB:Extended --era Run3 --magField 0T
                                           [3]: cmsDriver.py step3  -s RAW2DIGI,L1Reco,RECO,RECOSIM,EI,PAT,NANO,VALIDATION:@standardValidation+@miniAODValidation,DQM:@standardDQM+@ExtraHLT+@miniAODDQM+@nanoAODDQM --conditions auto:phase1_2021_realistic_0T --datatier GEN-SIM-RECO,MINIAODSIM,NANOAODSIM,DQMIO -n 1 --eventcontent RECOSIM,MINIAODSIM,NANOEDMAODSIM,DQM --geometry DB:Extended --era Run3 --magField 0T
                                           [4]: cmsDriver.py step4  -s HARVESTING:@standardValidation+@standardDQM+@ExtraHLT+@miniAODValidation+@miniAODDQM+@nanoAODDQM --conditions auto:phase1_2021_realistic_0T --mc  --geometry DB:Extended --scenario pp --filetype DQM --era Run3 -n 1 --magField 0T

now 11834.24 has -n 1 in every step.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@mmusich
Copy link
Contributor Author

mmusich commented Dec 15, 2021

test parameters:

  • workflows = 11834.24

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36503/27381

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Dec 15, 2021

@cmsbuild, please test

@kpedro88
Copy link
Contributor

@mmusich please don't add special workflow modifications in random places in relval_steps.py where nobody will ever find or remember them.

The actual issue here seems to be:

stepDict[stepName][k] = merge([{'-n':'1','--magField':'0T','--conditions':myGT}, stepDict[step][k]])

PUDataSets[ds]={'-n':10,'--pileup':'AVE_35_BX_25ns','--pileup_input':'das:/RelValMinBias_13/%s/GEN-SIM'%(name,)}

specialWF.setup(upgradeStepDict, k, upgradeProperties[year][k])

upgradeStepDict[stepNamePU][k]=merge([PUDataSets[k2],upgradeStepDict[stepName][k]])

specialWF.setupPU(upgradeStepDict, k, upgradeProperties[year][k])

i.e., the '-n':'1' setting is overridden by the PUDataSets contents.

Please see #36505 for an appropriate fix.

@mmusich
Copy link
Contributor Author

mmusich commented Dec 15, 2021

@kpedro88 I was not aware of this setupPU function.

@mmusich mmusich closed this Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants