Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure HLTProcess adds all (End)Paths to the schedule [12.2.X] #36474

Merged

Conversation

missirol
Copy link
Contributor

backport of #36422

PR description:

This PR updates HLTProcess (which controls the output of hltGetConfiguration), ensuring that (End)Paths appended by HLTProcess are added to the schedule.

For example, if one currently specifies --output minimal, the corresponding output .root file is not produced.

The issue was spotted by @silviodonato.

PR validation:

Manual tests, e.g.

for ec in minimal full all none ; do
  hltGetConfiguration /dev/CMSSW_12_2_0/GRun --globaltag auto:run3_hlt --data \
    --customise HLTrigger/Configuration/customizeHLTforCMSSW.customiseFor2018Input \
    --input /store/data/Run2018D/EphemeralHLTPhysics7/RAW/v1/000/323/790/00000/B543D251-40F1-CB46-A6A1-046CF3D78D6D.root \
    --era Run2_2018 --output ${ec} --max-events 10 > hlt_${ec}.py
  cmsRun hlt_${ec}.py &> hlt_${ec}.log
  ls -ltra .
done
unset ec

If this PR is a backport, please specify the original PR and why you need to backport that PR:

#36422

Backport of a bugfix for HLT development, to include it in the next full CMSSW release, i.e. 12_2_0.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 13, 2021

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_2_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

type bugfix

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f7f0f/21226/summary.html
COMMIT: b72c689
CMSSW: CMSSW_12_2_X_2021-12-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36474/21226/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250608
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3250586
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Dec 14, 2021

+1

@cmsbuild cmsbuild merged commit 61479ba into cms-sw:CMSSW_12_2_X Dec 14, 2021
@missirol missirol deleted the devel_hltGetConfOutputMods_122X branch December 14, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants