Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_2_X] Replace Candidate GT by named GT in conddb script unit tests and update offline Run-3 data GT #36409

Merged

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Dec 8, 2021

PR description:

See description in #36402

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #36402

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2021

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_12_2_X.

It involves the following packages:

  • CondCore/Utilities (db)
  • Configuration/AlCa (alca)

@malbouis, @yuanchao, @cmsbuild, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Dec 8, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ad201e/21083/summary.html
COMMIT: d093cd6
CMSSW: CMSSW_12_2_X_2021-12-07-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36409/21083/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250608
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3250574
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor Author

tvami commented Dec 8, 2021

+1

  • already merged in master

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Dec 9, 2021

+1

  • Update of the test script is needed in view of the ConfDB policy of deleting Candidates GTs older than 6 months
  • GT update for 'run3_data' requested for the 2021 CRAFT and Pilot Beam reReco. The differences with respect the previous tag are in the 16 updated multi-IOV tags related to ECAL PF Cluster corrections

@cmsbuild cmsbuild merged commit 3fe3f3b into cms-sw:CMSSW_12_2_X Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants