-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition from sigcpp-2 to sigcpp-3 #36343
Conversation
test parameters:
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36343/27101 ERROR: Build errors found during clang-tidy run.
|
code-checks with cms.week0.PR_cddbe267/52.0-a6892e1bac283099e8d8790601b27c6d |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36343/27180
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
@alja , can you please apply https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36343/27180/code-format.patch patch to your branch |
@alja , can you please apply the patch https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36343/27180/code-format.patch |
@smuzaffar I applied the patch. I'm sorry I have missed the previous message 3 days ago. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36343/27304
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages:
@cmsbuild, @makortel, @Dr15Jones, @alja can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b8956/21196/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
@alja this looks good now, can you please sign it for visualization |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
These changes are needed by sigc++ version 3