-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement step skipping more consistently for Patatrack workflows #36341
Conversation
test parameters: |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36341/27095
|
A new Pull Request was created by @kpedro88 (Kevin Pedro) for master. It involves the following packages:
@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
urgent |
type bugfix |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-062217/20948/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 We are waiting for this fix before building pre3. Please review this PR at your earliest convenient time. Thanks! |
+upgrade |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
PR description:
#36309 fixed Run3 but broke 2018. The skipping of ALCA and Nano steps is now reimplemented to be more consistent with the special workflow pattern.
PR validation:
Checked that steps generated by runTheMatrix for both workflows 10824.505 and 11634.505 include only the desired steps for each case (Run2/2018 and Run3).