MTD reconstruction: time back-propagation accounting for variable speed along trajectory

[fabiocos]

PR description:

This PR proposes a revision of last stage of RecoMTD, namely TrackExtenderWithMTD and TofPIDProducer to account for the fact that the particle speed along the trajectory is not constantly equal to the initial one, as assumed in the current code.

Effects are expected to be negligible for relativistic particles, but may induce O(several ps) biases for low momentum particles, depending on the mass used in the time back-propagation.

This PR adds three new ValueMap into the AOD event content, corresponding to the time of flight for three mass hypotheses (pion, kaon and proton) to be used by the TofPIDProducer.

The PR is based on the work documented in https://indico.cern.ch/event/1098101/contributions/4620485/attachments/2349416/4007038/MTDDPG_RECO_20211119.pdf

PR validation:

The code has been tested with both no PU and =200 samples (geometry scenario D77, 100 events).

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36202/26800

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

• RecoMTD/TimingIDTools (upgrade, reconstruction)
• RecoMTD/TrackExtender (upgrade, reconstruction)

@jpata, @AdrianoDee, @srimanob, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5441d/20669/summary.html
COMMIT: e207800
CMSSW: CMSSW_12_2_X_2021-11-22-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36202/20669/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 206 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3247021
• DQMHistoTests: Total failures: 774
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3246225
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36202/27074

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #36202 was updated. @jpata, @AdrianoDee, @srimanob, @cmsbuild, @slava77 can you please check and sign again.

[fabiocos]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5441d/20935/summary.html
COMMIT: afda4d7
CMSSW: CMSSW_12_2_X_2021-12-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36202/20935/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 203 differences found in the comparisons
• DQMHistoTests: Total files compared: 41
• DQMHistoTests: Total histograms compared: 3041955
• DQMHistoTests: Total failures: 783
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3041149
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 40 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 175 log files, 37 edm output root files, 41 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #36202 afda4d7

• code changes are in line with the PR description and the follow up review
• jenkins tests pass and comparisons with the baseline show moderate changes in MTD-related quantities in tracks (including in 4D vertices)
  • additionally, new products are saved Product added floatedmValueMap_trackExtenderWithMTD_generalTrackTofP_*, generalTrackTofK, and generalTrackTofPi

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1