MuonAlignment ASAN bug fix and DB output update #36145
Conversation
| @@ -84,7 +84,7 @@ MuonMisalignedProducer::MuonMisalignedProducer(const edm::ParameterSet& p) | |||
| esTokenGEM_(esConsumes(edm::ESInputTag("", "idealForMuonMisalignedProducer"))) {} | |||
|
|
|||
| //__________________________________________________________________________________________________ | |||
| MuonMisalignedProducer::~MuonMisalignedProducer() = default; | |||
| MuonMisalignedProducer::~MuonMisalignedProducer() {} | |||
There was a problem hiding this comment.
I think the = default; is the recommended way of doing this
There was a problem hiding this comment.
The code-format tool changed this. do you want to keep = default;?
There was a problem hiding this comment.
Interesting, @makortel @smuzaffar I thought the default was the preferred option
There was a problem hiding this comment.
There was a problem hiding this comment.
It is, and I'm a bit surprised that code-checks would change away from = default. We have plenty of those in .cc files.
There was a problem hiding this comment.
It is, and I'm a bit surprised that code-checks would change away from
= default. We have plenty of those in.ccfiles.
no, it was my mistake.
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36145/26680
|
|
A new Pull Request was created by @hyunyong for master. It involves the following packages:
@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| @@ -284,8 +284,8 @@ void MuonAlignment::saveCSCSurveyToDB(void) { | |||
| throw cms::Exception("NotAvailable") << "PoolDBOutputService not available"; | |||
|
|
|||
| // Get alignments and errors | |||
| Alignments cscAlignments{}; | |||
| SurveyErrors cscSurveyErrors{}; | |||
| Alignments* cscAlignments = new Alignments(); | |||
There was a problem hiding this comment.
here the original was the preferred solution
PR description:
Resolve #36053
Resolve cms-AlCaDB/AlCaTools#43
DB output service migration for MuonAlignment (cms-AlCaDB/AlCaTools#28)