-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ECAL and GEM tags to 122X GTs #36083
Conversation
test parameters:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36083/26558
|
A new Pull Request was created by @malbouis for master. It involves the following packages:
@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ec37d9/20446/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
GT diffs look good and as expected differences in https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_2_X_2021-11-10-1100+ec37d9/46786/validateJR.html appear only in mcRun3 and mcRun4 workflows. @camendola @simonepigazzini could you confirm the differences are as expected (I could not find Marco Cipriani's git handle, so feel free to tag his as well)? |
I had a look and the differences look as expected |
+alca
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Change GTs in referece to cms-sw/cmssw#36083
PR description:
This PR is to include the ECAL Linearization Constant tag in the mcRun4 and mcRun3 GTs, as requested in https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4529.html
It also includes a new EcalLaserAPDPNRatios ECAL tag in the Run3 offline GT.
There is also the inclusion of the GEMeMap tag in the run3 offline GT, as requested in https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4524.html.
The tags included in the GTs are:
ECAL Linearization Constant (in mcRun4 and mcRun3 GTs except the design one),
EcalTPGLinearizationConst_UL_2018_mc_EE_BTCP_116_SIC_1
EcalLaserAPDPNRatios (in Run3 offline GT),
EcalLaserAPDPNRatios_offline_Run3_v1
GEMeMap (in the Run3 offline GT),
GEMeMap_Full_v2
Since all 122X Queues have been created we also updated all other GTs in autoCond to 122X.
The diffs in GTs are below. We expect to see differences only in the mcRun4 and mcRun3 (except the design one) and Run3 offline GTs:
run1_design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_mcRun1_design_v1/121X_mcRun1_design_v6
run1_mc
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_mcRun1_realistic_v1/121X_mcRun1_realistic_v6
run1_mc_hi
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_mcRun1_HeavyIon_v1/121X_mcRun1_HeavyIon_v7
run2_mc_50ns
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_mcRun2_startup_v1/121X_mcRun2_startup_v8
run2_mc_l1stage1
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_mcRun2_asymptotic_l1stage1_v1/121X_mcRun2_asymptotic_l1stage1_v8
run2_design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_mcRun2_design_v1/121X_mcRun2_design_v8
run2_mc_pre_vfp
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_mcRun2_asymptotic_preVFP_v1/121X_mcRun2_asymptotic_preVFP_v8
run2_mc
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_mcRun2_asymptotic_v1/121X_mcRun2_asymptotic_v8
run2_mc_cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_mcRun2cosmics_asymptotic_deco_v1/121X_mcRun2cosmics_asymptotic_deco_v8
run2_mc_hi
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_mcRun2_HeavyIon_v1/121X_mcRun2_HeavyIon_v8
run2_mc_pa
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_mcRun2_pA_v1/121X_mcRun2_pA_v8
run2_data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_dataRun2_v1/121X_dataRun2_v11
run2_data_HEfail
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_dataRun2_HEfail_v1/121X_dataRun2_HEfail_v11
run2_data_relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_dataRun2_relval_v1/121X_dataRun2_relval_v11
run2_data_promptlike_hi
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_dataRun2_PromptLike_HI_v1/121X_dataRun2_PromptLike_HI_v10
run3_hlt
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_dataRun3_HLT_v1/121X_dataRun3_HLT_v11
run2_hlt_relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_dataRun2_HLT_relval_v1/121X_dataRun2_HLT_relval_v11
run3_data_express
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_dataRun3_Express_v1/121X_dataRun3_Express_v11
run3_data_prompt
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_dataRun3_Prompt_v1/121X_dataRun3_Prompt_v10
run3_data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_dataRun3_v1/121X_dataRun3_v10
phase1_2017_design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_mc2017_design_v1/121X_mc2017_design_v9
phase1_2017_realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_mc2017_realistic_v1/121X_mc2017_realistic_v9
phase1_2017_cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_mc2017cosmics_realistic_deco_v1/121X_mc2017cosmics_realistic_deco_v9
phase1_2017_cosmics_peak
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_mc2017cosmics_realistic_peak_v1/121X_mc2017cosmics_realistic_peak_v9
phase1_2018_design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_upgrade2018_design_v1/121X_upgrade2018_design_v8
phase1_2018_realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_upgrade2018_realistic_v1/121X_upgrade2018_realistic_v8
phase1_2018_realistic_rd
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_upgrade2018_realistic_RD_v1/121X_upgrade2018_realistic_RD_v8
phase1_2018_realistic_hi
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_upgrade2018_realistic_HI_v1/121X_upgrade2018_realistic_HI_v8
phase1_2018_realistic_HEfail
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_upgrade2018_realistic_HEfail_v1/121X_upgrade2018_realistic_HEfail_v8
phase1_2018_cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_upgrade2018cosmics_realistic_deco_v1/121X_upgrade2018cosmics_realistic_deco_v10
phase1_2018_cosmics_peak
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_upgrade2018cosmics_realistic_peak_v1/121X_upgrade2018cosmics_realistic_peak_v8
phase1_2021_design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_mcRun3_2021_design_v1/121X_mcRun3_2021_design_v16
phase1_2021_realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_mcRun3_2021_realistic_v1/121X_mcRun3_2021_realistic_v18
phase1_2021_cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_mcRun3_2021cosmics_realistic_deco_v1/121X_mcRun3_2021cosmics_realistic_deco_v18
phase1_2021_realistic_hi
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_mcRun3_2021_realistic_HI_v1/121X_mcRun3_2021_realistic_HI_v18
phase1_2023_realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_mcRun3_2023_realistic_v1/121X_mcRun3_2023_realistic_v17
phase1_2024_realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_mcRun3_2024_realistic_v1/121X_mcRun3_2024_realistic_v17
phase2_realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//122X_mcRun4_realistic_v1/121X_mcRun4_realistic_v8
PR validation:
runTheMatrix.py -l limited,136.897,7.23,12834.0 --ibeos -j16
if this PR is a backport please specify the original PR and why you need to backport that PR:
it is not a backport