Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.1.X] Update of mkFit as in 12_2_0 (backport of PR #35974) #36075

Merged
merged 2 commits into from
Nov 13, 2021

Conversation

mmasciov
Copy link
Contributor

PR description:

Backport of PR #35974 to 12_1_X, together with cms-sw/cmsdist#7444.
The reason for the backport is to ensure that data reprocessing makes use of the same mkFit developments available in 12_2_X.

It requires cms-sw/cmsdist#7444.

PR validation:

Please refer to PR #35974.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 10, 2021

A new Pull Request was created by @mmasciov (Mario Masciovecchio) for CMSSW_12_1_X.

It involves the following packages:

  • RecoTracker/MkFit (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Nov 10, 2021

@cmsbuild , please test with cms-sw/cmsdist#7444

@tvami
Copy link
Contributor

tvami commented Nov 10, 2021

backport of #35974

@mmasciov mmasciov changed the title [12.1.X] Backport of PR #35974 [12.1.X] Update of mkFit as in 12_2_0 (backport of PR #35974) Nov 10, 2021
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d822cd/20434/summary.html
COMMIT: 418ac2f
CMSSW: CMSSW_12_1_X_2021-11-10-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36075/20434/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 22814 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901440
  • DQMHistoTests: Total failures: 33897
  • DQMHistoTests: Total nulls: 6
  • DQMHistoTests: Total successes: 2867515
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.105 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 136.793 ): -0.031 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 136.874 ): -0.074 KiB JetMET/SUSYDQM
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: found differences in 1 / 41 workflows

@tvami
Copy link
Contributor

tvami commented Nov 11, 2021

urgent

  • TkAlignment would like to test mkFit with a rereco (in 12_1_X) so we'd need this in asap

@jpata
Copy link
Contributor

jpata commented Nov 11, 2021

Do we need a formal confirmation that changing the reco results in 12_1_X is OK (that no sample submission has been done)?

@qliphy
Copy link
Contributor

qliphy commented Nov 12, 2021

Do we need a formal confirmation that changing the reco results in 12_1_X is OK (that no sample submission has been done)?

@rappoccio @cms-sw/pdmv-l2 may confirm on this.
Anyway we don't have sample production with 12_1_X, which was released last week.

@jpata
Copy link
Contributor

jpata commented Nov 12, 2021

Anyway we don't have sample production with 12_1_X, which was released last week.

Thank you, that's what I thought but I wasn't sure. Approving this just now.

@jpata
Copy link
Contributor

jpata commented Nov 12, 2021

+reconstruction

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Nov 13, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants