Phase2-hgx293Y Add a test to verify the list of Valid DetId and their corners #35925

bsunanda · 2021-10-31T22:42:17Z

PR description:

Add a test to verify the list of Valid DetId and their corners for HGCal geometry

PR validation:

Make use of cfg's in Geometry/HGCalGeometry/test/python

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

cmsbuild · 2021-10-31T22:48:19Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35925/26331

This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35925/26331/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35925/26331/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

bsunanda · 2021-10-31T22:58:00Z

@cmsbuild Please test

cmsbuild · 2021-10-31T23:03:13Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35925/26332

This PR adds an extra 16KB to repository

cmsbuild · 2021-10-31T23:03:36Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Geometry/HGCalGeometry (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2021-11-01T00:20:12Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5fff3/20126/summary.html
COMMIT: 923c554
CMSSW: CMSSW_12_2_X_2021-10-31-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35925/20126/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

135.4

----- Begin Fatal Exception 01-Nov-2021 00:21:44 CET-----------------------
An exception of category 'EventSetupConflict' occurred while
   [0] Calling beginJob
Exception Message:
two EventSetup Sources want to deliver type="PPSAssociationCuts" label=""
 from record PPSAssociationCutsRcd. The two providers are 
1) type="PPSAssociationCutsESSource" label="ppsAssociationCutsESSource"
2) type="PoolDBESSource" label="GlobalTag"
Please either
   remove one of these Sources
   or find a way of configuring one of them so it does not deliver this data
   or use an es_prefer statement in the configuration to choose one.
----- End Fatal Exception -------------------------------------------------

136.8311

----- Begin Fatal Exception 01-Nov-2021 00:22:17 CET-----------------------
An exception of category 'EventSetupConflict' occurred while
   [0] Calling beginJob
Exception Message:
two EventSetup Sources want to deliver type="PPSAssociationCuts" label=""
 from record PPSAssociationCutsRcd. The two providers are 
1) type="PPSAssociationCutsESSource" label="ppsAssociationCutsESSource"
2) type="PoolDBESSource" label="GlobalTag"
Please either
   remove one of these Sources
   or find a way of configuring one of them so it does not deliver this data
   or use an es_prefer statement in the configuration to choose one.
----- End Fatal Exception -------------------------------------------------

136.7611

----- Begin Fatal Exception 01-Nov-2021 00:22:18 CET-----------------------
An exception of category 'EventSetupConflict' occurred while
   [0] Calling beginJob
Exception Message:
two EventSetup Sources want to deliver type="PPSAssociationCuts" label=""
 from record PPSAssociationCutsRcd. The two providers are 
1) type="PPSAssociationCutsESSource" label="ppsAssociationCutsESSource"
2) type="PoolDBESSource" label="GlobalTag"
Please either
   remove one of these Sources
   or find a way of configuring one of them so it does not deliver this data
   or use an es_prefer statement in the configuration to choose one.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

4.64.6_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1/step2_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1.log
136.72411136.72411_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM/step2_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM.log
136.72412136.72412_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMININANO_data2016UL_HIPM+HARVESTDR2_REMININANO_data2016UL_HIPM/step2_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMININANO_data2016UL_HIPM+HARVESTDR2_REMININANO_data2016UL_HIPM.log

Expand to see more relval errors ...

AddOn Tests

fastsim1

----- Begin Fatal Exception 01-Nov-2021 00:21:33 CET-----------------------
An exception of category 'EventSetupConflict' occurred while
   [0] Calling beginJob
Exception Message:
two EventSetup Sources want to deliver type="PPSAssociationCuts" label=""
 from record PPSAssociationCutsRcd. The two providers are 
1) type="PPSAssociationCutsESSource" label="ppsAssociationCutsESSource"
2) type="PoolDBESSource" label="GlobalTag"
Please either
   remove one of these Sources
   or find a way of configuring one of them so it does not deliver this data
   or use an es_prefer statement in the configuration to choose one.
----- End Fatal Exception -------------------------------------------------

fastsim2

----- Begin Fatal Exception 01-Nov-2021 00:21:35 CET-----------------------
An exception of category 'EventSetupConflict' occurred while
   [0] Calling beginJob
Exception Message:
two EventSetup Sources want to deliver type="PPSAssociationCuts" label=""
 from record PPSAssociationCutsRcd. The two providers are 
1) type="PPSAssociationCutsESSource" label="ppsAssociationCutsESSource"
2) type="PoolDBESSource" label="GlobalTag"
Please either
   remove one of these Sources
   or find a way of configuring one of them so it does not deliver this data
   or use an es_prefer statement in the configuration to choose one.
----- End Fatal Exception -------------------------------------------------

hlt_mc_Fake1

----- Begin Fatal Exception 01-Nov-2021 00:25:36 CET-----------------------
An exception of category 'EventSetupConflict' occurred while
   [0] Calling beginJob
Exception Message:
two EventSetup Sources want to deliver type="PPSAssociationCuts" label=""
 from record PPSAssociationCutsRcd. The two providers are 
1) type="PPSAssociationCutsESSource" label="ppsAssociationCutsESSource"
2) type="PoolDBESSource" label="GlobalTag"
Please either
   remove one of these Sources
   or find a way of configuring one of them so it does not deliver this data
   or use an es_prefer statement in the configuration to choose one.
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

srimanob · 2021-11-01T02:00:22Z

The test failure seems to related to the new GT, issue is opened in #35927

srimanob · 2021-11-01T02:05:01Z

@cmsbuild please test with #35766

cmsbuild · 2021-11-01T05:22:38Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a5fff3/20129/summary.html
COMMIT: 923c554
CMSSW: CMSSW_12_2_X_2021-10-31-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35925/20129/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 42
DQMHistoTests: Total histograms compared: 2901890
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2901862
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
Checked 177 log files, 37 edm output root files, 42 DQM output files
TriggerResults: no differences found

srimanob · 2021-11-01T05:26:16Z

+Upgrade

This PR is to add tests.

civanch · 2021-11-01T08:39:18Z

+1

cmsbuild · 2021-11-01T08:39:51Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-11-01T10:37:02Z

+1

Add a test to verify the list of Valid DetId and their corners

f014af7

cmsbuild added this to the CMSSW_12_2_X milestone Oct 31, 2021

cmsbuild added code-checks-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Oct 31, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Oct 31, 2021

Code check

923c554

cmsbuild added code-checks-pending and removed code-checks-rejected labels Oct 31, 2021

cmsbuild added tests-started and removed tests-pending labels Oct 31, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 31, 2021

cmsbuild added tests-rejected and removed tests-started labels Nov 1, 2021

srimanob mentioned this pull request Nov 1, 2021

PPSAssociationCuts causes EventSetupConflict #35927

Closed

cmsbuild added requires-external tests-started and removed tests-rejected labels Nov 1, 2021

cmsbuild added tests-approved and removed tests-started labels Nov 1, 2021

cmsbuild added upgrade-approved and removed upgrade-pending labels Nov 1, 2021

cmsbuild added fully-signed geometry-approved and removed geometry-pending pending-signatures labels Nov 1, 2021

cmsbuild added orp-approved and removed orp-pending labels Nov 1, 2021

cmsbuild merged commit d1de9af into cms-sw:master Nov 1, 2021

cmsbuild mentioned this pull request Nov 1, 2021

rootmodule: Updated root to tip of branch master cms-sw/cmsdist#7421

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2-hgx293Y Add a test to verify the list of Valid DetId and their corners #35925

Phase2-hgx293Y Add a test to verify the list of Valid DetId and their corners #35925

bsunanda commented Oct 31, 2021

cmsbuild commented Oct 31, 2021

bsunanda commented Oct 31, 2021

cmsbuild commented Oct 31, 2021

cmsbuild commented Oct 31, 2021

cmsbuild commented Nov 1, 2021

srimanob commented Nov 1, 2021

srimanob commented Nov 1, 2021

cmsbuild commented Nov 1, 2021

srimanob commented Nov 1, 2021

civanch commented Nov 1, 2021

cmsbuild commented Nov 1, 2021

qliphy commented Nov 1, 2021

Phase2-hgx293Y Add a test to verify the list of Valid DetId and their corners #35925

Phase2-hgx293Y Add a test to verify the list of Valid DetId and their corners #35925

Conversation

bsunanda commented Oct 31, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Oct 31, 2021

bsunanda commented Oct 31, 2021

cmsbuild commented Oct 31, 2021

cmsbuild commented Oct 31, 2021

cmsbuild commented Nov 1, 2021

RelVals

RelVals-INPUT

AddOn Tests

srimanob commented Nov 1, 2021

srimanob commented Nov 1, 2021

cmsbuild commented Nov 1, 2021

Comparison Summary

srimanob commented Nov 1, 2021

civanch commented Nov 1, 2021

cmsbuild commented Nov 1, 2021

qliphy commented Nov 1, 2021