Include PPS Association Cuts in data and MC GTs #35914

runTheMatrix.py -l limited,145,1325.516,281,1307,10424,7.21,11224,11024.2,250200.182,7.4,12034,7.23,12834,23234,138.2,138.1,136.8642,136.88811,136.897,11925 --ibeos -j16

It was tested together with PR #35766

if this PR is a backport please specify the original PR and why you need to backport that PR:

No backport is foreseen

malbouis · 2021-10-29T16:36:12Z

test parameters:

workflow=145,1325.516,281,1307,10424,7.21,11224,11024.2,250200.182,7.4,12034,7.23,12834,23234,138.2,138.1,136.8642,136.88811,136.897,11925
pull_request=PPS: consume association cuts from DB #35766, introduce COPYPASTER3 and use it as step2 in wf 138.3 #35890

cmsbuild · 2021-10-29T16:36:36Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35914/26313

This PR adds an extra 12KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/AlCa/python/autoCond.py modified in PR(s): Add ppRef modifier instead of a GT #35909

cmsbuild · 2021-10-29T16:37:05Z

A new Pull Request was created by @malbouis for master.

It involves the following packages:

Configuration/AlCa (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

malbouis · 2021-10-29T16:38:07Z

please test

cmsbuild · 2021-10-29T20:30:18Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c428e/20082/summary.html
COMMIT: 06d3a8b
CMSSW: CMSSW_12_2_X_2021-10-29-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35914/20082/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMServicesDemo had ERRORS

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3c428e/10424.0_TTbar_13+2017Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3c428e/11024.2_TTbar_13UP18HEfailINPUT+TTbar_13UP18HEfailINPUT+DigiFullHEfail+RecoFullHEfail+HARVESTFullHEfail+NanoFullHEfail
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3c428e/11224.0_TTbar_13+2018Design+TTbar_13TeV_TuneCUETP8M1_GenSim+Digi+RecoFakeHLT+HARVESTFakeHLT
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3c428e/11925.0_GluGluTo2Jets_14TeV+2021PU+GluGluTo2Jets_M_300_2000_14TeV_Exhume_GenSim+DigiPU+RecoPU+HARVESTPU+Nano
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3c428e/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecNan+HARVESTRecNan
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3c428e/136.8642_RunJetHT2018BHEfail+RunJetHT2018BHEfail+HLTDR2_2018+RECODR2_2018reHLT_skimJetHT_Prompt_HEfail+HARVEST2018_HEfail
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3c428e/136.897_RunCosmics2021CRUZET+RunCosmics2021CRUZET+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCRUN3
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3c428e/138.1_RunCosmics2021+RunCosmics2021+RECOCOSDPROMPTRUN3+ALCACOSDPROMPTRUN3+HARVESTDCPROMPTRUN3
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3c428e/138.2_RunCosmics2021+RunCosmics2021+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3c428e/145.0_HydjetQ_B12_5020GeV_2015+HydjetQ_B12_5020GeV_2015+DIGIHI2015+RECOHI2015+HARVESTHI2015
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3c428e/250200.182_ZEE_13UP18_RD+ZEE_13UP18_RD+DIGIPRMXUP18_PU25_RD+RECOPRMXUP18_PU25_L1TEgDQM_RD+HARVESTUP18_PU25_L1TEgDQM_RD
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3c428e/7.21_Cosmics_UP17+Cosmics_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-3c428e/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 42
DQMHistoTests: Total histograms compared: 2901440
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2901412
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
Checked 177 log files, 37 edm output root files, 42 DQM output files
TriggerResults: no differences found

tvami · 2021-10-30T07:41:05Z

+alca

unit test failure is know and is irrelevant
other test pass
probably it would have been better to have a Run-2 specific tag for the Run-2 GTs, but it's not used in Run-2 so it's somewhat irrelevant

cmsbuild · 2021-10-30T07:41:26Z

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

tvami · 2021-10-30T08:46:10Z

Hi @qliphy this PR can go in first, we dont need to wait for #35766
I'm wondering if you are fine merging this with the bad unit test, since it's a known ongoing issue (that will prob not get resolved over the weekend)?

qliphy · 2021-10-30T13:08:01Z

merge

mmusich · 2021-10-30T15:22:11Z

after this has been merged there are PR test errors:
#35909 (comment)

mmusich · 2021-10-30T15:29:59Z

can go in first, we dont need to wait for #35766

This is not correct, this PR succeeded integration tests because it was tested together with #35766 (as that PR removes the duplicated record insertion), see #35914 (comment).
The removal of the ESSource should have been done in this PR.

francescobrivio · 2021-10-30T15:33:18Z

can go in first, we dont need to wait for #35766

This is not correct, this PR succeeded integration tests because it was tested together with #35766 (as that PR removes the duplicated record insertion), see #35914 (comment). The removal of the ESSource should have been done in this PR.

@tvami can you include this fix in your PR #35909 ? we need to fix the broken IB asap

tvami · 2021-10-30T18:13:17Z

We discussed with @francescobrivio privately that what I'd need to include is already in #35766 so we should make that go in asap, so I made that PR urgent. Sorry for not realizing that these were not independent.

Include PPS Association Cuts in data and MC GTs

06d3a8b

cmsbuild added this to the CMSSW_12_2_X milestone Oct 29, 2021

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Oct 29, 2021

cmsbuild added the requires-external label Oct 29, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 29, 2021

cmsbuild added tests-started and removed tests-pending labels Oct 29, 2021

cmsbuild added tests-rejected and removed tests-started labels Oct 29, 2021

tvami mentioned this pull request Oct 30, 2021

PPS: consume association cuts from DB #35766

Merged

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Oct 30, 2021

cmsbuild added orp-approved and removed orp-pending labels Oct 30, 2021

cmsbuild merged commit 817dc63 into cms-sw:master Oct 30, 2021

qliphy mentioned this pull request Oct 30, 2021

Add ppRef modifier instead of a GT #35909

Merged

qliphy mentioned this pull request Nov 1, 2021

CTPPS related issue in several IB workflows #35928

Closed

cmsbuild mentioned this pull request Nov 1, 2021

rootmodule: Updated root to tip of branch master cms-sw/cmsdist#7421

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Include PPS Association Cuts in data and MC GTs #35914

Include PPS Association Cuts in data and MC GTs #35914

malbouis commented Oct 29, 2021

malbouis commented Oct 29, 2021 •

edited

Loading

cmsbuild commented Oct 29, 2021

cmsbuild commented Oct 29, 2021

malbouis commented Oct 29, 2021

cmsbuild commented Oct 29, 2021

tvami commented Oct 30, 2021

cmsbuild commented Oct 30, 2021

tvami commented Oct 30, 2021

qliphy commented Oct 30, 2021

mmusich commented Oct 30, 2021

mmusich commented Oct 30, 2021 •

edited

Loading

francescobrivio commented Oct 30, 2021

tvami commented Oct 30, 2021

Include PPS Association Cuts in data and MC GTs #35914

Include PPS Association Cuts in data and MC GTs #35914

Conversation

malbouis commented Oct 29, 2021

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

malbouis commented Oct 29, 2021 • edited Loading

cmsbuild commented Oct 29, 2021

cmsbuild commented Oct 29, 2021

malbouis commented Oct 29, 2021

cmsbuild commented Oct 29, 2021

Unit Tests

Comparison Summary

tvami commented Oct 30, 2021

cmsbuild commented Oct 30, 2021

tvami commented Oct 30, 2021

qliphy commented Oct 30, 2021

mmusich commented Oct 30, 2021

mmusich commented Oct 30, 2021 • edited Loading

francescobrivio commented Oct 30, 2021

tvami commented Oct 30, 2021

malbouis commented Oct 29, 2021 •

edited

Loading

mmusich commented Oct 30, 2021 •

edited

Loading