Faster CSCCLCTDigi::clear()

[Dr15Jones]

PR description:

The clear was a substantial fraction of a short L1Repack job. This can be see in the IB page's IgProf report for workflow 136.731.

PR validation:

Code compiles. I ran workflow 136.731 which worked fine. I also ran igProf after the change and the function no longer shows up.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35888/26286

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• DataFormats/CSCDigi (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@dildick, @ptcox, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[Dr15Jones]

@cms-sw/reconstruction-l2 why isn't this also under reconstruction?

[slava77]

@cms-sw/reconstruction-l2 why isn't this also under reconstruction?

CSCDigi is sim

[ptcox]

I guess you're saying that DataFormats/CSCDigi has historically been put under the auspices of Simulation? It's the stuff in the real RAW data stream which define what we have to put in CSCDigi's. Then in simulation we create the equivalent stuff and stick that in CSCDigi's too. The original point of Digis was to package the available data in a form optimized for use in Reco,. Tim Slava Krutelyov wrote on 10/28/21 20:14:

…

@cms-sw/reconstruction-l2 <https://github.com/orgs/cms-sw/teams/reconstruction-l2> why isn't this also under reconstruction? CSCDigi is sim — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#35888 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGYLHU2YAHHQ7F2KVOUQCTUJGHINANCNFSM5G5N7E4Q>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[cmsbuild]

-1

Failed Tests: UnitTests RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d3609/20027/summary.html
COMMIT: 87133c0
CMSSW: CMSSW_12_1_X_2021-10-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35888/20027/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMServicesDemo had ERRORS
---> test runtestRecoTauTagHLTProducers had ERRORS

RelVals-INPUT

• 138.3138.3_RunMinimumBias2021Splash+RunMinimumBias2021Splash+RECODR3Splash+HARVESTDR3/step2_RunMinimumBias2021Splash+RunMinimumBias2021Splash+RECODR3Splash+HARVESTDR3.log

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 2901440
• DQMHistoTests: Total failures: 17
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2901400
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[Dr15Jones]

please test

The two unit tests failures are happening in the IB and the RelVal test doesn't seem to related to code that was changed.

[cmsbuild]

-1

Failed Tests: UnitTests RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1d3609/20032/summary.html
COMMIT: 87133c0
CMSSW: CMSSW_12_1_X_2021-10-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35888/20032/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMServicesDemo had ERRORS
---> test runtestRecoTauTagHLTProducers had ERRORS

RelVals-INPUT

• 138.3138.3_RunMinimumBias2021Splash+RunMinimumBias2021Splash+RECODR3Splash+HARVESTDR3/step2_RunMinimumBias2021Splash+RunMinimumBias2021Splash+RECODR3Splash+HARVESTDR3.log

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 14 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 2901440
• DQMHistoTests: Total failures: 18
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2901399
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[Dr15Jones]

The same unit tests and RelVal workflow are failing when running tests with other PRs. Therefore they are not do to this change.

[civanch]

+1

the problem in unit tests cannot be connected with this PR.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

merge