-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for multiprocessing in RecoTrack Validation script #35884
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35884/26281
|
A new Pull Request was created by @lecriste (Leonardo Cristella) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
It did not crash and produced plots |
@lecriste would you mind changing the PR title by making it a little more self-explanatory (again for the sake of being able to read the release notes) |
-1 Failed Tests: UnitTests RelVals-INPUT Unit TestsI found errors in the following unit tests: ---> test TestDQMServicesDemo had ERRORS RelVals-INPUT
Comparison SummarySummary:
|
failures are unrelated. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
merge |
PR description:
This PR fixes a race condition introduced with the
multiprocessing
package.No change is expected in the output as this concerns a plotting script.
PR validation:
The errors reported in #35827 are gone.