Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add process.runType.commissioning_run in the supported types of beampixel_dqm_sourceclient-live #35869

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 28, 2021

PR description:

To fix a crash observed in the test beam when a run of DQM type commissioning_run was taken (see log)

PR validation:

None

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, but it should be backported.

@francescobrivio
Copy link
Contributor

@cmsbuild please test

@francescobrivio
Copy link
Contributor

FYI @dinardo

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35869/26268

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @pbo0, @pmandrik can you please review it and eventually sign? Thanks.
@battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@mmusich
Copy link
Contributor Author

mmusich commented Oct 28, 2021

@jfernan2 seems this is failing unit test but on the TestDQMServicesDemo.
I don't quite understand from the log what's wrong, can you clarify?

@mmusich
Copy link
Contributor Author

mmusich commented Oct 28, 2021

ah OK I see now #35868. So the problem is generalized.

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bb0404/20006/summary.html
COMMIT: 5b3982e
CMSSW: CMSSW_12_1_X_2021-10-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35869/20006/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMServicesDemo had ERRORS

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901440
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2901412
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1
Backport tested in Online DQM
Unit Test errors are unrelated

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar removed this from the CMSSW_12_1_X milestone Oct 29, 2021
@perrotta
Copy link
Contributor

+1

  • Unit Test errors are unrelated

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit a78bfae into cms-sw:master Oct 29, 2021
@mmusich mmusich deleted the fix_beam_pixel_client branch November 3, 2021 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants