-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add process.runType.commissioning_run
in the supported types of beampixel_dqm_sourceclient-live
#35869
Conversation
…ixel_dqm_sourceclient-live
@cmsbuild please test |
FYI @dinardo |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35869/26268
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @pbo0, @pmandrik can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
@jfernan2 seems this is failing unit test but on the TestDQMServicesDemo. |
ah OK I see now #35868. So the problem is generalized. |
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test TestDQMServicesDemo had ERRORS Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1
|
merge |
PR description:
To fix a crash observed in the test beam when a run of DQM type
commissioning_run
was taken (see log)PR validation:
None
if this PR is a backport please specify the original PR and why you need to backport that PR:
Not a backport, but it should be backported.