Phase2-hgx293X Extend the possibility of new cells needed for rotated full wafers #35864

bsunanda · 2021-10-27T15:45:23Z

PR description:

Extend the possibility of new cells needed for rotated full wafers of HGCal

PR validation:

Tested using cfg's in Geometry/HGCalCommonData/test/python

if this PR is a backport please specify the original PR and why you need to report that PR:

Nothing special

cmsbuild · 2021-10-27T15:52:32Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35864/26251

This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35864/26251/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35864/26251/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

bsunanda · 2021-10-27T15:55:45Z

@cmsbuild Please test

cmsbuild · 2021-10-27T16:04:35Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35864/26252

This PR adds an extra 24KB to repository

cmsbuild · 2021-10-27T16:04:58Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Geometry/HGCalCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2021-10-27T21:49:21Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a758c/19992/summary.html
COMMIT: e7a5aba
CMSSW: CMSSW_12_1_X_2021-10-27-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35864/19992/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2a758c/11634.914_TTbar_14TeV+2021_DDDDB+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-2a758c/38634.0_TTbar_14TeV+2026D86+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 14450 differences found in the comparisons
DQMHistoTests: Total files compared: 42
DQMHistoTests: Total histograms compared: 2901440
DQMHistoTests: Total failures: 253160
DQMHistoTests: Total nulls: 326
DQMHistoTests: Total successes: 2647932
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
Checked 177 log files, 37 edm output root files, 42 DQM output files
TriggerResults: found differences in 2 / 41 workflows

civanch · 2021-10-28T00:26:25Z

+1

fix for `TestDQMServicesDemo` unit test [12.1.X]

…121x Fix the Patatrack pixel local reconstruction running on CPU

Fix for multiprocessing in RecoTrack Validation script [12.1.X]

add `process.runType.commissioning_run` in the supported types of `beampixel_dqm_sourceclient-live` [12.1.X]

bsunanda · 2021-11-03T11:19:01Z

@AdrianoDee, @srimanob Please approve

srimanob · 2021-11-03T15:43:54Z

Hi @bsunanda
Is this PR not related to testing only? Why do we see changes in all Phase-2 workflows?

bsunanda · 2021-11-03T16:46:54Z

No - it has some extension of cell structure. I tested with original as well as new ones. They give satisfactory results. Any small change in geometry makes perturbation in results

bsunanda · 2021-11-03T17:28:11Z

Please hold on - I am checking the code again

cmsbuild · 2021-11-04T21:26:04Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35864/26427

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/python/relval_standard.py modified in PR(s): Add DQM Matrix to RelVals #35678
- File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): restrict RunHI2011 to 182124:40, used in the short matrix wf 140.53 #35912, Add DQM Matrix to RelVals #35678, Use pdigi_hi_nogen for HI MC wfs #35028
- File HLTrigger/Configuration/python/customizeHLTforCMSSW.py modified in PR(s): [WIP] add fillPSetDescription to CkfTrackCandidateMakerBase and propagate it to CkfTrackCandidateMaker #35385

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35864/26427/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35864/26427/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35864/26427/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35864/26427/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

bsunanda · 2021-11-04T21:35:28Z

It was updated from a version CMSSW_12_1_X. So several new files get added. Close this in favor of #35997

cmsbuild added this to the CMSSW_12_1_X milestone Oct 27, 2021

cmsbuild added code-checks-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Oct 27, 2021

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Oct 27, 2021

cmsbuild added tests-started and removed tests-pending labels Oct 27, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 27, 2021

cmsbuild added tests-approved and removed tests-started labels Oct 27, 2021

cmsbuild added geometry-approved and removed geometry-pending labels Oct 28, 2021

smuzaffar modified the milestones: CMSSW_12_1_X, CMSSW_12_2_X Oct 29, 2021

lecriste and others added 3 commits October 29, 2021 10:48

Fix cms-sw#35827

1b89b83

HLT migration to 12_1_0_pre5 template

364cd6a

HLT migration to 12_1_0_pre5 template

9b2be04

cmsbuild mentioned this pull request Nov 1, 2021

Phase2-hgx294 Update the longitudinal structure for the V16 (D86) geometry of HGCal #35945

Merged

cmsbuild added 4 commits November 2, 2021 01:28

Merge pull request cms-sw#35930 from mmusich/devel_fixDQMUnitTest_12_1_X

3c65168

fix for `TestDQMServicesDemo` unit test [12.1.X]

Merge pull request cms-sw#35916 from fwyzard/fix_hltSiPixelRecHitSoA_…

3f27c8b

…121x Fix the Patatrack pixel local reconstruction running on CPU

Merge pull request cms-sw#35894 from mmusich/parallelValidation_12_1_X

679e644

Fix for multiprocessing in RecoTrack Validation script [12.1.X]

Merge pull request cms-sw#35895 from mmusich/fix_beam_pixel_client

b15182b

add `process.runType.commissioning_run` in the supported types of `beampixel_dqm_sourceclient-live` [12.1.X]

Sunanda added 3 commits November 3, 2021 17:51

Extend the possibility of new cells needed for rotated full wafers

0b1b856

Code check

949e9f2

comment th debug's

1fed725

Fix bugs in the new cell algorithm

f05ee1a

bsunanda force-pushed the Phase2-hgx293X branch from 8d108e8 to f05ee1a Compare November 4, 2021 21:17

cmsbuild added code-checks-pending dqm-pending geometry-pending hlt-pending pdmv-pending tests-pending and removed geometry-approved tests-approved code-checks-approved labels Nov 4, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Nov 4, 2021

bsunanda mentioned this pull request Nov 4, 2021

Phase2-hgx293A Extend the possibility of new cells needed for rotated full wafers #35997

Merged

bsunanda closed this Nov 4, 2021

bsunanda deleted the Phase2-hgx293X branch November 4, 2021 21:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2-hgx293X Extend the possibility of new cells needed for rotated full wafers #35864

Phase2-hgx293X Extend the possibility of new cells needed for rotated full wafers #35864

bsunanda commented Oct 27, 2021

cmsbuild commented Oct 27, 2021

bsunanda commented Oct 27, 2021

cmsbuild commented Oct 27, 2021

cmsbuild commented Oct 27, 2021

cmsbuild commented Oct 27, 2021

civanch commented Oct 28, 2021

bsunanda commented Nov 3, 2021

srimanob commented Nov 3, 2021

bsunanda commented Nov 3, 2021

bsunanda commented Nov 3, 2021

cmsbuild commented Nov 4, 2021

bsunanda commented Nov 4, 2021

Phase2-hgx293X Extend the possibility of new cells needed for rotated full wafers #35864

Phase2-hgx293X Extend the possibility of new cells needed for rotated full wafers #35864

Conversation

bsunanda commented Oct 27, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to report that PR:

cmsbuild commented Oct 27, 2021

bsunanda commented Oct 27, 2021

cmsbuild commented Oct 27, 2021

cmsbuild commented Oct 27, 2021

cmsbuild commented Oct 27, 2021

Comparison Summary

civanch commented Oct 28, 2021

bsunanda commented Nov 3, 2021

srimanob commented Nov 3, 2021

bsunanda commented Nov 3, 2021

bsunanda commented Nov 3, 2021

cmsbuild commented Nov 4, 2021

bsunanda commented Nov 4, 2021