-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run3-alca207 Update the macros used in IsoTrack calibration of HCAL #35831
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35831/26192
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35831/26195
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
-1 Failed Tests: RelVals RelVals
|
Hi @bsunanda where is this calibration happening? Only offline? I'm not sure how deep the review level should be, for example I see a lot of |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2989c9/19931/summary.html Comparison SummarySummary:
|
@yuanchao can you please review this one? |
This calibration is done offline after accumulation of statistics using the AlCaReco files |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Update the macros used in IsoTrack calibration of HCAL
PR validation:
Tested on MC samples reconstructed using DLPHIN algorithm
if this PR is a backport please specify the original PR and why you need to backport that PR:
Nothing special