-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dead source file CondTools/L1Trigger/src/Interval.icc
#35775
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35775/26130
|
A new Pull Request was created by @guitargeek (Jonas Rembser) for master. It involves the following packages:
@malbouis, @cmsbuild, @rekovic, @ggovi, @francescobrivio, @cecilecaillol, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0b005f/19811/summary.html Comparison SummarySummary:
|
+db |
Hi @rekovic, is this PR okay for you? |
Hi @guitargeek. Yes indeed. Thanks. |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR removes an unused source file with the rather obscure
.icc
extension, that is sometimes used for template code implementations. The file is not included anywhere and also can't be included anywhere by convention, because it is in asrc
directory and not aninterface
directory.PR validation:
CMSSW compiles.
if this PR is a backport please specify the original PR and why you need to backport that PR:
No backport intended.