Migration to DD4hep as default for all Run-3 workflows #35761

srimanob · 2021-10-21T09:26:22Z

PR description:

This is a PR to migrate DD4hep to be a default for Run-3 workflows.
Related issue: #35707

This PR includes:

Era: Update Run3 era to include dd4hep, update Run3_dd4hep for compatibility, introduce new Run3_DDD for DDD workflow,
Introduce .914 workflow for DDD,
Update short matrix, exclude .912 (DD4hep DB) as it becomes default (.0) now. Add .914,
Update Run-3 GT to DD4hep-base by default,
Update AutoCondModifiers from DD4hep to DDD modifier,
I use the chance to add one more short matrix workflow of D86 (no effect on DD4hep)

When this PR is merged, the migration should be transparent to all users. Nothing will change in cmsDriver. No need of --procModifier, no change in --era and --condition with autoCond GT.

Global Tag:

Added VeryForwardIdealGeometryRecord tag to 2017 ppRef GT to (partially) fix IB failure with workflow 136.8562 and 149.0 #35828:
Switch to DD4HEP for mcRun3 GTs by adding to the tags:

CSCRECODIGI_Geometry_120DD4hepV1
CSCRECO_Geometry_120DD4hepV1
DTRECO_Geometry_120DD4hepV1
GEMRECO_Geometry_120DD4hepV1
XMLFILE_Geometry_121DD4hepV2_Extended2021_mc with label "Extended"
HCALParameters_Geometry_120DD4hepV1
TKRECO_Geometry_121DD4hepV1
CTRECO_Geometry_120DD4hepV1
EBRECO_Geometry_120DD4hepV1
EERECO_Geometry_120DD4hepV1
EPRECO_Geometry_120DD4hepV1
HCALRECO_Geometry_120DD4hepV1
TKParameters_Geometry_120DD4hepV1
ZDCRECO_Geometry_120DD4hepV1
RPCRECO_Geometry_120DD4hepV1

Which also includes the latest XMLFILE tag (V2) announced in https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4508.html

The difference in GTs is here:
2017 realistic for ppRef5TeV https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/120X_mc2017_realistic_forppRef5TeV_v2/121X_mc2017_realistic_forppRef5TeV_v1

2021 design https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_design_v12/121X_mcRun3_2021_design_v13

2021 realistic https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_realistic_v14/121X_mcRun3_2021_realistic_v15

2021 cosmics https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021cosmics_realistic_deco_v14/121X_mcRun3_2021cosmics_realistic_deco_v15

2021 heavy ion https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2021_realistic_HI_v14/121X_mcRun3_2021_realistic_HI_v15

2023 realistic https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2023_realistic_v13/121X_mcRun3_2023_realistic_v14

2024 realistic https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/121X_mcRun3_2024_realistic_v13/121X_mcRun3_2024_realistic_v14

PR validation:

runTheMatrix.py --what upgrade -l 11634.0,11634.911,11634.914 --wm init
gives proper configurations.

if this PR is a backport please specify the original PR and why you need to backport that PR:

No need of backport AFAIK.

srimanob · 2021-10-21T09:28:54Z

test parameters:

workflows = 11634.914

cmsbuild · 2021-10-21T09:34:28Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35761/26105

This PR adds an extra 40KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/README.md modified in PR(s): Add run3 tracking low pu era #33532
- File Configuration/PyReleaseValidation/python/relval_2017.py modified in PR(s): [JMENanoAOD] Rework for Prompt #35614
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Add run3 tracking low pu era #33532, Phase 2 HLT menu targetting 7.5×10³⁴ cm⁻²s⁻¹ #35342
- File Configuration/StandardSequences/python/Eras.py modified in PR(s): Add run3 tracking low pu era #33532

cmsbuild · 2021-10-21T09:35:22Z

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

Configuration/AlCa (alca)
Configuration/Eras (operations)
Configuration/PyReleaseValidation (pdmv, upgrade)
Configuration/StandardSequences (operations)

@perrotta, @malbouis, @yuanchao, @jordan-martins, @bbilin, @wajidalikhan, @tvami, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @qliphy, @francescobrivio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @slomeo, @GiacomoSguazzoni, @JanFSchulte, @tocheng, @VinInn, @Martin-Grunewald, @missirol, @rovere, @lecriste, @mtosi, @ebrondol, @mmusich, @dgulhan, @kpedro88 this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

srimanob · 2021-10-21T09:37:11Z

@cmsbuild please test

Configuration/AlCa/python/autoCondModifiers.py

civanch · 2021-10-21T09:42:12Z

@srimanob , thank! this is what we need. @bsunanda , @cvuosalo , please comment. I would agree that we do not need .913 - Run3 DDD from xml.

cmsbuild · 2021-10-21T10:58:08Z

-1

Failed Tests: RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e2ed33/19792/summary.html
COMMIT: fd92731
CMSSW: CMSSW_12_1_X_2021-10-20-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35761/19792/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

312.0312.0_Pyquen_ZeemumuJets_pt10_2760GeV_2021+Pyquen_ZeemumuJets_pt10_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO/step1_Pyquen_ZeemumuJets_pt10_2760GeV_2021+Pyquen_ZeemumuJets_pt10_2760GeV_2021+DIGIHI2021MIX+RECOHI2021MIX+HARVESTHI2021PPRECO.log
23234.0

----- Begin Fatal Exception 21-Oct-2021 12:24:41 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing global begin Run run: 1
   [1] Prefetching for module OscarMTProducer/'g4SimHits'
   [2] Calling method for EventSetup module TrackerGeometricDetESModule/'trackerNumberingGeometry'
Exception Message:
No data of type "cms::DDCompactView" with label "" in record "IdealGeometryRecord"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

28234.0

----- Begin Fatal Exception 21-Oct-2021 12:25:29 CEST-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing global begin Run run: 1
   [1] Prefetching for module OscarMTProducer/'g4SimHits'
   [2] Calling method for EventSetup module TrackerGeometricDetESModule/'trackerNumberingGeometry'
Exception Message:
No data of type "cms::DDCompactView" with label "" in record "IdealGeometryRecord"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

AddOn Tests

hlt_mc_GRuncmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi -s GEN,SIM,DIGI,L1,DIGI2RAW --mc --scenario=pp -n 10 --conditions auto:run3_mc_GRun --relval 9000,50 --datatier "GEN-SIM-RAW" --eventcontent RAWSIM --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVal_Raw_GRun_MC.root : FAILED - time: date Thu Oct 21 12:08:39 2021-date Thu Oct 21 12:03:28 2021 s - exit: 35584
hlt_mc_GRun

----- Begin Fatal Exception 21-Oct-2021 12:07:22 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   Additional Info:
      [a] Input file file:RelVal_Raw_GRun_MC.root could not be opened.
      [b] Fatal Root Error: @SUB=TStorageFactoryFile::ReadBuffer
read from Storage::xread returned 256. Asked to read n bytes: 300 from offset: 0 with file size: 256

----- End Fatal Exception -------------------------------------------------

hlt_mc_GRun

----- Begin Fatal Exception 21-Oct-2021 12:08:39 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   Additional Info:
      [a] Input file file:RelVal_Raw_GRun_MC.root could not be opened.
      [b] Fatal Root Error: @SUB=TStorageFactoryFile::ReadBuffer
read from Storage::xread returned 256. Asked to read n bytes: 300 from offset: 0 with file size: 256

----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

srimanob · 2021-10-21T11:10:30Z

@cmsbuild please test

bbilin · 2021-10-26T16:20:13Z

+pdmv

srimanob · 2021-10-26T16:26:22Z

Hi Phat, thanks a lot for the feedback. One last comment, why do we still keep the 0.912 offset, here? This will not be used anymore, given we remove the XYZ.912 wfs. It does not hurt to keep for now, but if we need to drop them, better to keep in mind. Just asking to understand.

I keep .912 for now, in case we will use it for Phase-2 until the migration to DD4hep is done. .911 has phase-2 option while .912 not yet since nothing in DB for Phase-2 yet.

srimanob · 2021-10-26T16:29:25Z

@civanch Could you please resign?
The last commit is for comment only, no code changes. Thanks.

tvami · 2021-10-26T16:32:11Z

Hi @civanch please also consider signing in the name of geometry too not just simulation.

civanch · 2021-10-26T16:32:53Z

+1

srimanob · 2021-10-26T16:40:53Z

+Upgrade

I sign here first as the success of the test before the last commit. We can wait until the comparison is done before merging. Hope everything goes smoothly after IB includes it, finger crossed.

cmsbuild · 2021-10-26T17:09:40Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e2ed33/19951/summary.html
COMMIT: e7329c0
CMSSW: CMSSW_12_1_X_2021-10-25-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35761/19951/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e2ed33/11634.914_TTbar_14TeV+2021_DDDDB+TTbar_14TeV_TuneCP5_GenSim+Digi+Reco+HARVEST+ALCA
/data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e2ed33/38634.0_TTbar_14TeV+2026D86+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

No significant changes to the logs found
Reco comparison results: 10716 differences found in the comparisons
DQMHistoTests: Total files compared: 40
DQMHistoTests: Total histograms compared: 2589989
DQMHistoTests: Total failures: 10472
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2579494
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 39 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 168 log files, 37 edm output root files, 40 DQM output files
TriggerResults: found differences in 4 / 39 workflows

srimanob · 2021-10-26T17:31:51Z

@perrotta @qliphy
The PR test result is as expected,
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_1_X_2021-10-25-1100+e2ed33/46420/validateJR.html

The change is only Run-3 DDD workflows which are updated to DD4hep. Nothing else is changed. The new .914 workflow, Run-3 with DDD, runs fine. All unit tests, including HLT, run fine. So new GT with DD4hep-base works as expected.

I think we are in a good position to move, and see if something else will fail in IB because of this PR.

perrotta · 2021-10-26T18:02:07Z

+1

Let merge in the IB, as agreed today at the ORP

cmsbuild · 2021-10-26T18:02:33Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

cmsbuild added this to the CMSSW_12_1_X milestone Oct 21, 2021

cmsbuild added alca-pending code-checks-pending operations-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Oct 21, 2021

srimanob mentioned this pull request Oct 21, 2021

Set DD4hep as default of Run-3 workflow #35707

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 21, 2021

cmsbuild added tests-started and removed tests-pending labels Oct 21, 2021

mmusich reviewed Oct 21, 2021

View reviewed changes

Configuration/AlCa/python/autoCondModifiers.py Outdated Show resolved Hide resolved

cmsbuild added tests-rejected code-checks-pending tests-pending and removed tests-started tests-rejected code-checks-approved labels Oct 21, 2021

cmsbuild added tests-started and removed tests-pending labels Oct 21, 2021

cmsbuild added pdmv-approved and removed pdmv-pending labels Oct 26, 2021

cmsbuild added geometry-approved simulation-approved and removed simulation-pending geometry-pending labels Oct 26, 2021

cmsbuild added upgrade-approved and removed upgrade-pending labels Oct 26, 2021

cmsbuild added tests-approved and removed tests-started labels Oct 26, 2021

cmsbuild added fully-signed operations-approved orp-approved and removed operations-pending pending-signatures orp-pending labels Oct 26, 2021

cmsbuild merged commit 5503dc6 into cms-sw:master Oct 26, 2021

cmsbuild mentioned this pull request Oct 27, 2021

default initialize HiPuRhoProducer::postOrphan_ #35857

Merged

slava77 mentioned this pull request Oct 27, 2021

reco comparisons: add wf maps: DDD from DB wf 11634.914; D86 phase-2 wfs 38X34 for ttbar cms-sw/cms-bot#1654

Merged

srimanob mentioned this pull request Oct 27, 2021

Move Phase2 wf in the short matrix to D77 #35862

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migration to DD4hep as default for all Run-3 workflows #35761

Migration to DD4hep as default for all Run-3 workflows #35761

srimanob commented Oct 21, 2021 •

edited

Loading

srimanob commented Oct 21, 2021

cmsbuild commented Oct 21, 2021

cmsbuild commented Oct 21, 2021

srimanob commented Oct 21, 2021

civanch commented Oct 21, 2021

cmsbuild commented Oct 21, 2021

srimanob commented Oct 21, 2021

bbilin commented Oct 26, 2021

srimanob commented Oct 26, 2021

srimanob commented Oct 26, 2021

tvami commented Oct 26, 2021

civanch commented Oct 26, 2021

srimanob commented Oct 26, 2021

cmsbuild commented Oct 26, 2021

srimanob commented Oct 26, 2021

perrotta commented Oct 26, 2021

cmsbuild commented Oct 26, 2021

Migration to DD4hep as default for all Run-3 workflows #35761

Migration to DD4hep as default for all Run-3 workflows #35761

Conversation

srimanob commented Oct 21, 2021 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

srimanob commented Oct 21, 2021

cmsbuild commented Oct 21, 2021

cmsbuild commented Oct 21, 2021

srimanob commented Oct 21, 2021

civanch commented Oct 21, 2021

cmsbuild commented Oct 21, 2021

RelVals

AddOn Tests

srimanob commented Oct 21, 2021

bbilin commented Oct 26, 2021

srimanob commented Oct 26, 2021

srimanob commented Oct 26, 2021

tvami commented Oct 26, 2021

civanch commented Oct 26, 2021

srimanob commented Oct 26, 2021

cmsbuild commented Oct 26, 2021

Comparison Summary

srimanob commented Oct 26, 2021

perrotta commented Oct 26, 2021

cmsbuild commented Oct 26, 2021

srimanob commented Oct 21, 2021 •

edited

Loading