Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update L1TrackTrigger_cff.py #35559

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Update L1TrackTrigger_cff.py #35559

merged 1 commit into from
Oct 8, 2021

Conversation

tomalin
Copy link
Contributor

@tomalin tomalin commented Oct 6, 2021

The deleted line is no longer necessary, since the default value of TTStubAlgorithm_official_Phase2TrackerDigi_.zMatchingPS = cms.bool(True) already in https://github.com/cms-sw/cmssw/blob/master/L1Trigger/TrackTrigger/python/TTStubAlgorithmRegister_cfi.py#L17 .

The deleted line is no longer necessary, since the default value of TTStubAlgorithm_official_Phase2TrackerDigi_.zMatchingPS = cms.bool(True) already in https://github.com/cms-sw/cmssw/blob/master/L1Trigger/TrackTrigger/python/TTStubAlgorithmRegister_cfi.py#L17 .
@tomalin
Copy link
Contributor Author

tomalin commented Oct 6, 2021

@skinnari @rekovic were informed of this change.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35559/25793

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2021

A new Pull Request was created by @tomalin (Ian Tomalin) for master.

It involves the following packages:

  • Configuration/StandardSequences (operations)

@cmsbuild, @perrotta, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @lecriste, @mtosi, @ebrondol, @mmusich, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor

rekovic commented Oct 7, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-231c20/19454/summary.html
COMMIT: f228f88
CMSSW: CMSSW_12_1_X_2021-10-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35559/19454/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 3219394
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3219365
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 39 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Oct 8, 2021

+operations

  • It avoids a redefinition of a parameter with the same value as the default one: i.e. it does nothing, but it cleans up one line from the configuration

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Oct 8, 2021

+1

@cmsbuild cmsbuild merged commit d310d6e into cms-sw:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants