Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate module config in RecoTracker to use default seedingLayersEDProducer in cfipython v2 #35555

Merged
merged 1 commit into from
Oct 9, 2021

Conversation

jeongeun
Copy link
Contributor

@jeongeun jeongeun commented Oct 6, 2021

PR description:

Optimization of the python configurations: Improve maintainability by cleaning up the duplicated and cloning from the default/reference configurations. This is a follow-up PR from PR#35194.
This is the 2nd version. (1st version is PR#35549 )
As commented from slava in this PR#35194, we replaced "cms.PSet" in module "seedingLayersEDProducer" with "dict".

In this PR, 8 files changed.
modified: RecoTracker/ConversionSeedGenerators/python/ConversionStep2_cff.py
modified: RecoTracker/ConversionSeedGenerators/python/ConversionStep_cff.py
modified: RecoTracker/IterativeTracking/python/ElectronSeeds_cff.py
modified: RecoTracker/IterativeTracking/python/JetCoreRegionalStep_cff.py
modified: RecoTracker/IterativeTracking/python/PixelLessStep_cff.py
modified: RecoTracker/IterativeTracking/python/PixelPairStep_cff.py
modified: RecoTracker/IterativeTracking/python/TobTecStep_cff.py
modified: RecoTracker/SpecialSeedGenerators/python/CombinatorialSeedGeneratorForCosmicsP5_cff.py

PR validation:

Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_12_1_X, the basic test all passed in the CMSSW PR instructions.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35555/25786

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2021

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

  • RecoTracker/ConversionSeedGenerators (reconstruction)
  • RecoTracker/IterativeTracking (reconstruction)
  • RecoTracker/SpecialSeedGenerators (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jpata
Copy link
Contributor

jpata commented Oct 6, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-db02d9/19433/summary.html
COMMIT: 281f16e
CMSSW: CMSSW_12_1_X_2021-10-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35555/19433/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 3219394
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3219366
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 39 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

Copy link
Contributor

@jpata jpata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reco changes, good. A minor question inline.

TTRHBuilder = cms.string('WithTrackAngle'),
HitProducer = cms.string('siPixelRecHits'),
skipClusters = cms.InputTag('conv2Clusters'),
),
FPix = cms.PSet(
FPix = dict(
TTRHBuilder = cms.string('WithTrackAngle'),
HitProducer = cms.string('siPixelRecHits'),
skipClusters = cms.InputTag('conv2Clusters'),
),
TIB1 = cms.PSet(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry if I misunderstand, but why not doing PSet->dict here for TIB1? Is it because here FPix is defined, but TIB1 is not? Same goes for TIB2, TIB3 and others that are kept as PSet below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpata Yes, you are correct. TIB1, TIB2 TIB3 ...etc are not defined in fillDescriptions so I didn't replace it.

@jpata
Copy link
Contributor

jpata commented Oct 8, 2021

I did a diff between the config dump from 11834.21/step3 before & after this PR and saw no change, as expected.

@jpata
Copy link
Contributor

jpata commented Oct 9, 2021

+reconstruction

  • technical python config cleanup
  • no reco changes, no changes in the configdump

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Oct 9, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants