-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate module config in RecoTracker to use default seedingLayersEDProducer in cfipython v2 #35555
Conversation
A new Pull Request was created by @jeongeun (JeongEun Lee) for master. It involves the following packages:
@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-db02d9/19433/summary.html Comparison SummarySummary:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reco changes, good. A minor question inline.
TTRHBuilder = cms.string('WithTrackAngle'), | ||
HitProducer = cms.string('siPixelRecHits'), | ||
skipClusters = cms.InputTag('conv2Clusters'), | ||
), | ||
FPix = cms.PSet( | ||
FPix = dict( | ||
TTRHBuilder = cms.string('WithTrackAngle'), | ||
HitProducer = cms.string('siPixelRecHits'), | ||
skipClusters = cms.InputTag('conv2Clusters'), | ||
), | ||
TIB1 = cms.PSet( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry if I misunderstand, but why not doing PSet->dict here for TIB1? Is it because here FPix is defined, but TIB1 is not? Same goes for TIB2, TIB3 and others that are kept as PSet below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpata Yes, you are correct. TIB1, TIB2 TIB3 ...etc are not defined in fillDescriptions so I didn't replace it.
I did a diff between the config dump from 11834.21/step3 before & after this PR and saw no change, as expected. |
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Optimization of the python configurations: Improve maintainability by cleaning up the duplicated and cloning from the default/reference configurations. This is a follow-up PR from PR#35194.
This is the 2nd version. (1st version is PR#35549 )
As commented from slava in this PR#35194, we replaced "cms.PSet" in module "seedingLayersEDProducer" with "dict".
In this PR, 8 files changed.
modified: RecoTracker/ConversionSeedGenerators/python/ConversionStep2_cff.py
modified: RecoTracker/ConversionSeedGenerators/python/ConversionStep_cff.py
modified: RecoTracker/IterativeTracking/python/ElectronSeeds_cff.py
modified: RecoTracker/IterativeTracking/python/JetCoreRegionalStep_cff.py
modified: RecoTracker/IterativeTracking/python/PixelLessStep_cff.py
modified: RecoTracker/IterativeTracking/python/PixelPairStep_cff.py
modified: RecoTracker/IterativeTracking/python/TobTecStep_cff.py
modified: RecoTracker/SpecialSeedGenerators/python/CombinatorialSeedGeneratorForCosmicsP5_cff.py
PR validation:
Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_12_1_X, the basic test all passed in the CMSSW PR instructions.