-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add back DeepMET in NanoAOD #35460
add back DeepMET in NanoAOD #35460
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35460/25616
|
A new Pull Request was created by @yongbinfeng (Yongbin Feng) for master. It involves the following packages:
@cmsbuild, @mariadalfonso, @gouskos, @fgolf can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cdb467/19214/summary.html Comparison SummarySummary:
|
please test workflow 136.72412 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cdb467/19335/summary.html Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
|
plots available in https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/-/issues/131
no other changes |
please test (re-running with recent release) |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cdb467/20684/summary.html Comparison SummarySummary:
|
+xpog |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
PR to add back DeepMET to NanoAOD.
In the Nano developments DeepMET is skipped in the PR #34714 due to the conflicts and changes in
runMetCorAndUncFromMiniAOD
. This PR fixes the issues and will be able to read DeepMET from MiniAOD in the same way as chsMet, caloMet, etc. For the eras where DeepMET is computed in MiniAOD, it would be computed on the fly, inside thenanoAOD_recalibrateMETs
function.PR validation:
tested with runTheMatrix.py and passed all tests.
if this PR is a backport please specify the original PR and why you need to backport that PR:
not a backport.
notifying @steggema @mseidel42 and @mariadalfonso