Tracker phase2 bricked pixel localreco cmssw 12 1 x

[franzglessgen]

PR description:

Update phase-2 Tracker local reconstruction framework to include clusterizer and CPE algorithms for the Inner Tracker (IT).
Configurations with bricked pixels were introduced in CMSSW with PR#34120 (geometry) and PR#35173 (digitizer).

Clusterizer and CPE are implemented as classes derived from the current PixelThresholdClusterizer and PixelCPEGeneric classes with specialized methods for bricked pixels.
The algorithms are activated for the phase-2 tracker geometry T27 containing bricked pixels in TEPX&TFPX, as well as the central 1 (3) module(s) of TBPX L2 (L3 and L4).

Tracking step added following the same approach used for T22 (

using CPE generic algo everywhere in the InnerTracker).

PR validation:

Specific validation done using FourMuExtendedPt_1_200 events: runTheMatrix workflow 36210.0 (T25 reference) and 39010.0 (T27 proposed). This generated cfg files which were modified: the Muon pT was chosen to be between 199 and 200 and samples of size 5000 were used for creating the attached plots (using phase2_reco_pixelntuple_cfg.py)
Verified that the PR passes the basic test procedure suggested in the CMSSW PR instructions

The following plots show that the hits are correctly reconstructed according to the bricked geometry. The residues in Y become better with an increasing size in X for both the barrel and the endcaps. The endcap plots have a _EC.png appendix. All other plots come from the analysis of the hits in the bricked region (layer 2, eta < 0.35 , layer 3, eta < 0.6, layer 4, eta < 0.44) apart fron the resZ and resRphi plots which run over the whole detector excluding layer 1.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35441/25584

• This PR adds an extra 216KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Update DD4HEP GT with latest developments #35436, Add run3 tracking low pu era #33532, Phase 2 HLT menu targetting 7.5×10³⁴ cm⁻²s⁻¹ #35342, Add NanoAOD DQM to RelVal wfs #35412
  • File Configuration/StandardSequences/python/Eras.py modified in PR(s): Add run3 tracking low pu era #33532
  • File RecoLocalTracker/SiPixelClusterizer/plugins/PixelThresholdClusterizer.cc modified in PR(s): Fix Rare Undefined Behavior in PixelThresholdClusterizer #35275

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35441/25584/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35441/25584/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35441/25585

• This PR adds an extra 176KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Update DD4HEP GT with latest developments #35436, Add run3 tracking low pu era #33532, Phase 2 HLT menu targetting 7.5×10³⁴ cm⁻²s⁻¹ #35342, Add NanoAOD DQM to RelVal wfs #35412
  • File Configuration/StandardSequences/python/Eras.py modified in PR(s): Add run3 tracking low pu era #33532
  • File RecoLocalTracker/SiPixelClusterizer/plugins/PixelThresholdClusterizer.cc modified in PR(s): Fix Rare Undefined Behavior in PixelThresholdClusterizer #35275

[cmsbuild]

A new Pull Request was created by @franzglessgen for master.

It involves the following packages:

• CondFormats/SiPixelTransient (db, reconstruction)
• Configuration/Eras (operations)
• Configuration/Geometry (geometry, upgrade)
• Configuration/ProcessModifiers (operations)
• Configuration/PyReleaseValidation (pdmv, upgrade)
• Configuration/StandardSequences (operations)
• RecoLocalTracker/SiPixelClusterizer (reconstruction)
• RecoLocalTracker/SiPixelRecHits (reconstruction)
• RecoTracker/MeasurementDet (reconstruction)
• RecoTracker/TransientTrackingRecHit (reconstruction)

@bbilin, @wajidalikhan, @ianna, @ggovi, @perrotta, @civanch, @makortel, @cmsbuild, @davidlange6, @Dr15Jones, @cvuosalo, @mdhildreth, @AdrianoDee, @kskovpen, @slava77, @jpata, @qliphy, @fabiocos, @francescobrivio, @malbouis, @jordan-martins, @srimanob, @tvami can you please review it and eventually sign? Thanks.
@felicepantaleo, @kpedro88, @Martin-Grunewald, @OzAmram, @threus, @mmusich, @slomeo, @vargasa, @makortel, @JanFSchulte, @dgulhan, @missirol, @seemasharmafnal, @ferencek, @GiacomoSguazzoni, @rovere, @VinInn, @ebrondol, @mtosi, @fabiocos, @dkotlins, @lecriste, @gpetruc, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

test parameters:

• workflow = 39034.0

[mmusich]

@cmsbuild, please test

[jpata]

+reconstruction

• introduces a modifier phase2_brickedPixels and corresponding clusterizers for urgent bricked pixel studies
• no reco differences expected/observed
• the duplication was put into the issue Duplication of clusterizers for bricked pixels #35519, to be reviewed as soon as the studies are completed

[tvami]

+db

• see comment above:
  Tracker phase2 bricked pixel localreco cmssw 12 1 x #35441 (comment)

[AdrianoDee]

+upgrade

[jordan-martins]

+1

[bbilin]

+1

[tvami]

@cms-sw/geometry-l2 please sign asap, this is needed for pre4

[cvuosalo]

+1

[tvami]

@cmsbuild , ping

[tvami]

@perrotta @qliphy this is essentially fully signed

[qliphy]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.