Protect storage accounting UDP messages from NaN

[Dr15Jones]

PR description:

NaN's were being reported from the values computed using sqrt. This most likely was from the different variables not being updated atomically together.

PR validation:

Code compiles

fixes #35142
fixes #29412

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35362/25438

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• Utilities/StorageFactory (core)

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1049a1/18807/summary.html
COMMIT: 1c36203
CMSSW: CMSSW_12_1_X_2021-09-21-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35362/18807/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @srimanob Add GPU workflow to runTheMatrix #35263
• @makortel Fix addOnTests.py option -t for python3 #35348
• @bsunanda Run3-hcx322 Take care of Sim Geometry definition #35349
• @CMSTrackerDPG Fix undefined behavior in the SiPixelDigitizer #35337
• @Dr15Jones Use esConsumes in TSGFromL2Muon #35327
• @fwyzard Add support for the gpu modifier at HLT #34978

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1049a1/18807/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1049a1/18807/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3211080
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3211046
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 39 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[makortel]

+1

I still suspect the "sigma" values are not what they were intended to be (#29412 (comment)), but at least this PR should remove the NaNs.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[vkuznet]

from monitoring point of view all release we run on a GRID writes data to our end-points and the fix is desired in all of them.

[qliphy]

+1