Remove unused headers for phys & misc packages #35252

yuanchao · 2021-09-13T14:26:19Z

PR description:

This is the last batch of unused header removal.

Following the issue #31505, the following headers are unused in several package:

PhysicsTools/FWLite/interface/WSelectorFast.h
PhysicsTools/MVAComputer/interface/MVAModuleHelper.h
PhysicsTools/PatExamples/interface/WPlusJetsEventSelector.h
PhysicsTools/PatUtils/interface/JetSelector.h
PhysicsTools/PatUtils/interface/JetSelector.icc
PhysicsTools/PatUtils/interface/PatSelectorByFlags.h
PhysicsTools/PatUtils/interface/RefHelper.h
PhysicsTools/SelectorUtils/interface/Variables.h
PhysicsTools/UtilAlgos/interface/DummyMatchSelector.h
PhysicsTools/UtilAlgos/interface/EventSelector.h
PhysicsTools/UtilAlgos/interface/MCMatchSelector.h
PhysicsTools/UtilAlgos/interface/NtpProducer.h
PhysicsTools/UtilAlgos/interface/SelectedOutputCollectionTrait.h
PhysicsTools/UtilAlgos/interface/SelectionAdderTrait.h
PhysicsTools/UtilAlgos/interface/StoreContainerTrait.h
PhysicsTools/UtilAlgos/interface/TwoObjectCalculator.h
PhysicsTools/Utilities/interface/GammaPropagator.h
PhysicsTools/Utilities/interface/GammaZInterference.h
PhysicsTools/Utilities/interface/Number.h
PhysicsTools/Utilities/interface/ZLineShape.h
TopQuarkAnalysis/TopTools/interface/TopologyWorker.h
TrackingTools/AnalyticalJacobians/interface/CurvilinearJacobian.h
TrackingTools/GsfTools/interface/GaussianSumUtilities.h
TrackingTools/GsfTools/interface/GaussianSumUtilities.icc
TrackingTools/PatternTools/interface/MediumProperties.h
TrackingTools/Records/interface/Records.h

PR validation:

Code compiles. Run local limited runTheMatrix.py tests.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport and no backport forseen.

cmsbuild · 2021-09-13T14:32:31Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35252/25229

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File EventFilter/DTRawToDigi/interface/DTROS25Data.h modified in PR(s): Remove unused headers in several package. #35105
- File EventFilter/ESRawToDigi/interface/ESCrcKchipFast.h modified in PR(s): Remove unused headers in several package. #35105
- File EventFilter/EcalRawToDigi/interface/ECALUnpackerException.h modified in PR(s): Remove unused headers in several package. #35105
- File EventFilter/EcalRawToDigi/interface/MyWatcher.h modified in PR(s): Remove unused headers in several package. #35105
- File EventFilter/RPCRawToDigi/interface/RPCRawSynchro.h modified in PR(s): Remove unused headers in several package. #35105
- File EventFilter/Utilities/interface/ModuleWeb.h modified in PR(s): Remove unused headers in several package. #35105
- File EventFilter/Utilities/interface/config_json.h modified in PR(s): Remove unused headers in several package. #35105
- File HeavyFlavorAnalysis/SpecificDecay/interface/BPHMuonChargeSelect.h modified in PR(s): Remove unused headers in several package. #35105
- File HeavyFlavorAnalysis/SpecificDecay/interface/BPHParticleChargeSelect.h modified in PR(s): Remove unused headers in several package. #35105
- File IOPool/Common/interface/CustomStreamer.h modified in PR(s): Remove unused headers in several package. #35105
- File JetMETCorrections/InterpolationTables/interface/BoxNDScanner.h modified in PR(s): Remove unused headers in several package. #35105
- File JetMETCorrections/InterpolationTables/interface/MultivariateFunctorScanner.h modified in PR(s): Remove unused headers in several package. #35105
- File JetMETCorrections/InterpolationTables/interface/rescanArray.h modified in PR(s): Remove unused headers in several package. #35105
- File JetMETCorrections/Type1MET/interface/CorrectedMETProducerT.h modified in PR(s): Remove unused headers in several package. #35105

cmsbuild · 2021-09-13T14:32:55Z

A new Pull Request was created by @yuanchao (Yuan CHAO) for master.

It involves the following packages:

EventFilter/DTRawToDigi (reconstruction)
EventFilter/ESRawToDigi (reconstruction)
EventFilter/EcalRawToDigi (reconstruction)
EventFilter/RPCRawToDigi (reconstruction)
EventFilter/Utilities (daq, reconstruction)
HeavyFlavorAnalysis/SpecificDecay (analysis)
IOPool/Common (core)
JetMETCorrections/InterpolationTables (analysis)
JetMETCorrections/Type1MET (reconstruction)
PhysicsTools/FWLite (analysis)
PhysicsTools/MVAComputer (analysis)
PhysicsTools/PatExamples (analysis)
PhysicsTools/PatUtils (reconstruction)
PhysicsTools/SelectorUtils (reconstruction)
PhysicsTools/UtilAlgos (analysis)
PhysicsTools/Utilities (analysis)
TopQuarkAnalysis/TopTools (analysis)
TrackingTools/AnalyticalJacobians (reconstruction)
TrackingTools/GsfTools (reconstruction)
TrackingTools/PatternTools (reconstruction)
TrackingTools/Records (reconstruction)

@smuzaffar, @Dr15Jones, @makortel, @emeschi, @cmsbuild, @slava77, @jpata, @santocch, @smorovic can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @felicepantaleo, @hatakeyamak, @emilbols, @argiro, @Martin-Grunewald, @wddgit, @thomreis, @ahinzmann, @demuller, @mmusich, @seemasharmafnal, @mmarionncern, @calderona, @makortel, @JanFSchulte, @jhgoh, @jdolen, @sscruz, @cericeci, @simonepigazzini, @trocino, @abbiendi, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @bellan, @nhanvtran, @gkasieczka, @schoef, @ebrondol, @mtosi, @dgulhan, @clelange, @AlexDeMoor, @HuguesBrun, @rchatter, @battibass, @Fedespring, @JyothsnaKomaragiri, @lecriste, @gpetruc, @mariadalfonso, @andrzejnovak this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

makortel · 2021-09-13T14:36:40Z

@cmsbuild, please test

jpata · 2021-09-13T14:54:59Z

There is some overlap with the PR #35105

EventFilter/DTRawToDigi/interface/DTROS25Data.h
EventFilter/ESRawToDigi/interface/ESCrcKchipFast.h
JetMETCorrections/InterpolationTables/interface/BoxNDScanner.h
JetMETCorrections/InterpolationTables/interface/MultivariateFunctorScanner.h
JetMETCorrections/InterpolationTables/interface/rescanArray.h
JetMETCorrections/Type1MET/interface/CorrectedMETProducerT.h
(list may be incomplete, please verify yourself)

Can you please remove from this PR any file already touched by 35105?

yuanchao · 2021-09-13T15:00:15Z

There is some overlap with the PR #35105

EventFilter/DTRawToDigi/interface/DTROS25Data.h
EventFilter/ESRawToDigi/interface/ESCrcKchipFast.h
JetMETCorrections/InterpolationTables/interface/BoxNDScanner.h
JetMETCorrections/InterpolationTables/interface/MultivariateFunctorScanner.h
JetMETCorrections/InterpolationTables/interface/rescanArray.h
JetMETCorrections/Type1MET/interface/CorrectedMETProducerT.h
(list may be incomplete, please verify yourself)

Can you please remove from this PR any file already touched by 35105?

Ouch. I thought I've removed them. Fixing

cmsbuild · 2021-09-13T17:03:37Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35252/25240

This PR adds an extra 24KB to repository
Found files with invalid states:
- EventFilter/EcalRawToDigi/interface/MyWatcher.h:
  - Deleted: bee8337
  - Added: bec9a31
- EventFilter/Utilities/interface/ModuleWeb.h:
  - Deleted: bee8337
  - Added: bec9a31
- EventFilter/Utilities/interface/config_json.h:
  - Deleted: bee8337
  - Added: bec9a31
- IOPool/Common/interface/CustomStreamer.h:
  - Deleted: bee8337
  - Added: bec9a31
- HeavyFlavorAnalysis/SpecificDecay/interface/BPHParticleChargeSelect.h:
  - Deleted: bee8337
  - Added: bec9a31
- EventFilter/ESRawToDigi/interface/ESCrcKchipFast.h:
  - Deleted: bee8337
  - Added: bec9a31
- EventFilter/EcalRawToDigi/interface/ECALUnpackerException.h:
  - Deleted: bee8337
  - Added: bec9a31
- EventFilter/DTRawToDigi/interface/DTROS25Data.h:
  - Deleted: bee8337
  - Added: bec9a31
- HeavyFlavorAnalysis/SpecificDecay/interface/BPHMuonChargeSelect.h:
  - Deleted: bee8337
  - Added: bec9a31
- EventFilter/RPCRawToDigi/interface/RPCRawSynchro.h:
  - Deleted: bee8337
  - Added: bec9a31
- JetMETCorrections/InterpolationTables/interface/BoxNDScanner.h:
  - Deleted: bee8337
  - Added: bec9a31
- JetMETCorrections/InterpolationTables/interface/rescanArray.h:
  - Deleted: bee8337
  - Added: bec9a31
- JetMETCorrections/InterpolationTables/interface/MultivariateFunctorScanner.h:
  - Deleted: bee8337
  - Added: bec9a31
- JetMETCorrections/Type1MET/interface/CorrectedMETProducerT.h:
  - Deleted: bee8337
  - Added: bec9a31

cmsbuild · 2021-09-13T17:04:04Z

Pull request #35252 was updated. @jpata, @cmsbuild, @santocch, @slava77 can you please check and sign again.

yuanchao · 2021-09-13T17:14:39Z

@cmsbuild please test

cmsbuild · 2021-09-13T20:18:25Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a01080/18570/summary.html
COMMIT: bec9a31
CMSSW: CMSSW_12_1_X_2021-09-13-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35252/18570/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 3001001
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3000979
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

jpata · 2021-09-14T12:31:13Z

Can you please update the list of removed files in the PR description following #35252 (comment)? Thanks!

yuanchao · 2021-09-14T14:14:31Z

Can you please update the list of removed files in the PR description following #35252 (comment)? Thanks!

It's now updated.

jpata · 2021-09-16T10:53:21Z

I checked the git history of all headers, and did a quick google search for each for possible non-cmssw use / references in documentation. To me, all look like they can be removed, as they are unused in cmssw, in some cases duplicates, and basically untouched since the git migration 8 years ago.

For example, https://github.com/cms-sw/cmssw/blob/6d2f66057131baacc2fcbdd203588c41c885b42c/TrackingTools/AnalyticalJacobians/interface/CurvilinearJacobian.h looks like an outdated version of https://github.com/cms-sw/cmssw/blob/6d2f66057131baacc2fcbdd203588c41c885b42c/TrackingTools/AnalyticalJacobians/interface/AnalyticalCurvilinearJacobian.h.

https://github.com/cms-sw/cmssw/blob/6d2f66057131baacc2fcbdd203588c41c885b42c/PhysicsTools/UtilAlgos/interface/MCMatchSelector.h is an outdated version of https://github.com/cms-sw/cmssw/blob/6d2f66057131baacc2fcbdd203588c41c885b42c/CommonTools/UtilAlgos/interface/MCMatchSelector.h.

jpata · 2021-09-16T10:54:40Z

+reconstruction

for bec9a31
technical
checked according to Remove unused headers for phys & misc packages #35252 (comment)
no reco changes observed

qliphy · 2021-09-17T01:48:56Z

+1

qliphy · 2021-09-17T01:49:26Z

merge

santocch · 2021-09-23T12:35:00Z

+1

cmsbuild · 2021-09-23T12:35:26Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Remove unused headers for phys/event filter packages

bee8337

cmsbuild added this to the CMSSW_12_1_X milestone Sep 13, 2021

cmsbuild added analysis-pending code-checks-pending core-pending daq-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Sep 13, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 13, 2021

cmsbuild added tests-started and removed tests-pending labels Sep 13, 2021

add back duplicated file removal in cms-sw#35105

bec9a31

cmsbuild added code-checks-pending tests-pending and removed core-pending daq-pending tests-started code-checks-approved labels Sep 13, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 13, 2021

yuanchao changed the title ~~Remove unused headers for phys/event filter & misc packages~~ Remove unused headers for phys & misc packages Sep 13, 2021

cmsbuild added tests-started and removed tests-pending labels Sep 13, 2021

cmsbuild added tests-approved and removed tests-started labels Sep 13, 2021

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Sep 16, 2021

cmsbuild added orp-approved and removed orp-pending labels Sep 17, 2021

cmsbuild merged commit 443c56f into cms-sw:master Sep 17, 2021

cmsbuild mentioned this pull request Sep 20, 2021

Update Geant4 to 10.7.2 cms-sw/cmsdist#7316

Merged

cmsbuild added analysis-approved fully-signed and removed analysis-pending pending-signatures labels Sep 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove unused headers for phys & misc packages #35252

Remove unused headers for phys & misc packages #35252

yuanchao commented Sep 13, 2021 •

edited

Loading

cmsbuild commented Sep 13, 2021

cmsbuild commented Sep 13, 2021

makortel commented Sep 13, 2021

jpata commented Sep 13, 2021

yuanchao commented Sep 13, 2021

cmsbuild commented Sep 13, 2021

cmsbuild commented Sep 13, 2021

yuanchao commented Sep 13, 2021

cmsbuild commented Sep 13, 2021

jpata commented Sep 14, 2021

yuanchao commented Sep 14, 2021 •

edited

Loading

jpata commented Sep 16, 2021

jpata commented Sep 16, 2021

qliphy commented Sep 17, 2021

qliphy commented Sep 17, 2021

santocch commented Sep 23, 2021

cmsbuild commented Sep 23, 2021

Remove unused headers for phys & misc packages #35252

Remove unused headers for phys & misc packages #35252

Conversation

yuanchao commented Sep 13, 2021 • edited Loading

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Sep 13, 2021

cmsbuild commented Sep 13, 2021

makortel commented Sep 13, 2021

jpata commented Sep 13, 2021

yuanchao commented Sep 13, 2021

cmsbuild commented Sep 13, 2021

cmsbuild commented Sep 13, 2021

yuanchao commented Sep 13, 2021

cmsbuild commented Sep 13, 2021

Comparison Summary

jpata commented Sep 14, 2021

yuanchao commented Sep 14, 2021 • edited Loading

jpata commented Sep 16, 2021

jpata commented Sep 16, 2021

qliphy commented Sep 17, 2021

qliphy commented Sep 17, 2021

santocch commented Sep 23, 2021

cmsbuild commented Sep 23, 2021

yuanchao commented Sep 13, 2021 •

edited

Loading

yuanchao commented Sep 14, 2021 •

edited

Loading