Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Run3 offline GT #35202

Merged

Conversation

francescobrivio
Copy link
Contributor

@francescobrivio francescobrivio commented Sep 8, 2021

PR description:

This PR introduces a new key in autoCond to store the offline reprocessing GT for Run3, announced in the AlCaDB HN.
The new GT is: 113X_dataRun3_v1
The difference wrt dataRun2 GT is: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun2_v6/113X_dataRun3_v1

The PR also introduces a new relval workflow 136.897 that consumes this new GT.
I have some questions about this new workflow for @cms-sw/pdmv-l2 :

  • Is the number of the new workflow ok?
  • Should we add this to the standard matrix?

Finally, I modified the names of the steps of the Prompt relval workflow (138.1) since they consume the prompt GT and they shoul not be confused with the steps of the newly introduced Run3 offline workflow.

[EDIT]
As described in JIRA/PDMVRERECO-46 the new GT has already been update to v2 to include two new payloads for SiStripApvGain_FromParticles_GR10_v12_offline and TrackerSurfaceDeformations_v13_offline.
The new GT is: 113X_dataRun3_v2
And the difference wrt to v1 is: 113X_dataRun3_v2 vs 113X_dataRun3_v1

PR validation:

Tested with: runTheMatrix.py -l 138.1,136.897 --ibeos -j4

Backport:

Once this PR is signed off we will make backports to 12_0_X and 11_3_X

@francescobrivio
Copy link
Contributor Author

Test parameters:

  • worfklows=138.1,136.897

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35202/25141

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2021

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • Configuration/AlCa (alca)
  • Configuration/PyReleaseValidation (pdmv, upgrade)

@malbouis, @yuanchao, @jordan-martins, @chayanit, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @tocheng, @mmusich, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

Test parameters:

  • workflows=138.1,136.897

@AdrianoDee
Copy link
Contributor

test parameters:

  • worflows=138.1,136.897

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@AdrianoDee
Copy link
Contributor

please test

@francescobrivio
Copy link
Contributor Author

test parameters:

* worflows=138.1,136.897

@AdrianoDee I'm not sure this got processed correctly by the bot due to the typo...

@AdrianoDee
Copy link
Contributor

please abort

@tvami
Copy link
Contributor

tvami commented Sep 8, 2021

Test parameters:

  • workflows=138.1,136.897

this would have worked

@tvami
Copy link
Contributor

tvami commented Sep 8, 2021

test parameters:

  • workflows = 138.1,136.897

@tvami
Copy link
Contributor

tvami commented Sep 8, 2021

@cmsbuild , please test

@AdrianoDee
Copy link
Contributor

Sorry, we perfectly crossed and I'd missed your commands.

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-909f00/18461/summary.html
COMMIT: 62d25a3
CMSSW: CMSSW_12_1_X_2021-09-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35202/18461/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-909f00/136.897_RunCosmics2021CRUZET+RunCosmics2021CRUZET+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCRUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 3001001
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3000979
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Sep 9, 2021

+alca

@srimanob
Copy link
Contributor

+Upgrade

@kskovpen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

@cms-sw/pdmv-l2 are you guys ok with the wf naming?

I take the "+1" from PDMV as a "Yes"...

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit eca6295 into cms-sw:master Sep 10, 2021
@kskovpen
Copy link
Contributor

@cms-sw/pdmv-l2 are you guys ok with the wf naming?

I take the "+1" from PDMV as a "Yes"...

Yes, sorry, was in a robot mode. Unless @bbilin and @jordan-martins think otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants