Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate module config in RecoTracker{IterativeTracking} to use default cfipython v3 #35194

Merged
merged 3 commits into from
Sep 24, 2021
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions RecoTracker/IterativeTracking/python/MixedTripletStep_cff.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,13 @@
# SEEDING LAYERS
from RecoLocalTracker.SiStripClusterizer.SiStripClusterChargeCut_cfi import *
from RecoTracker.IterativeTracking.DetachedTripletStep_cff import detachedTripletStepSeedLayers
mixedTripletStepSeedLayersA = cms.EDProducer('SeedingLayersEDProducer',
layerList = cms.vstring('BPix2+FPix1_pos+FPix2_pos', 'BPix2+FPix1_neg+FPix2_neg'),
# layerList = cms.vstring('BPix1+BPix2+BPix3',
import RecoTracker.TkSeedingLayers.seedingLayersEDProducer_cfi as _seedmod
mixedTripletStepSeedLayersA = _seedmod.seedingLayersEDProducer.clone(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is now a redundant import RecoTracker.TkSeedingLayers.seedingLayersEDProducer_cfi as _mod on L164.
Please remove it there.

layerList = ['BPix2+FPix1_pos+FPix2_pos', 'BPix2+FPix1_neg+FPix2_neg'],
# layerList = ['BPix1+BPix2+BPix3',
# 'BPix1+BPix2+FPix1_pos', 'BPix1+BPix2+FPix1_neg',
# 'BPix1+FPix1_pos+FPix2_pos', 'BPix1+FPix1_neg+FPix2_neg',
# 'BPix2+FPix1_pos+FPix2_pos', 'BPix2+FPix1_neg+FPix2_neg'),
# 'BPix2+FPix1_pos+FPix2_pos', 'BPix2+FPix1_neg+FPix2_neg'],
BPix = cms.PSet(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the implementation in cfipython is

seedingLayersEDProducer = cms.EDProducer('SeedingLayersEDProducer',
  layerList = cms.vstring(),
  BPix = cms.PSet(),
  FPix = cms.PSet(),
  TIB = cms.PSet(),
  TID = cms.PSet(),
  TOB = cms.PSet(),
  TEC = cms.PSet(),
  MTIB = cms.PSet(),
  MTID = cms.PSet(),
  MTOB = cms.PSet(),
  MTEC = cms.PSet(),

So, I expect that the following should work (same for all other PSet in this module as well as in mixedTripletStepSeedLayersB in this file.

Suggested change
BPix = cms.PSet(
BPix = dict(

TTRHBuilder = cms.string('WithTrackAngle'),
HitProducer = cms.string('siPixelRecHits'),
Expand Down