-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/validation/RecoEgamma PHASE2 modifications #35192
/validation/RecoEgamma PHASE2 modifications #35192
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35192/25128
|
A new Pull Request was created by @archiron (Chiron) for master. It involves the following packages:
@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: ClangBuild Clang BuildI found compilation warning while trying to compile with clang. Command used:
See details on the summary page. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35192/25133
|
Pull request #35192 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again. |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35192/25220
|
Pull request #35192 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again. |
@@ -67,7 +67,7 @@ class ElectronMcFakeValidator : public ElectronDqmAnalyzerBase { | |||
|
|||
double maxPt_; | |||
double maxAbsEta_; | |||
double deltaR_; | |||
double deltaR_, deltaR2_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point. deltaR_ is not needed any more as class member, and it can be removed from them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, deltaR_ is removed. Please note that we have planned a PR during november/december in order to do such a modifications.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35192/25226
|
Pull request #35192 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ee01f0/18552/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Following a precedent PR (34439) we made a small correction in order to correct a little bug affecting this PR and the releases validations, where the barrel electrons are gone.
This can be seen on the picture below :
With our corrections the bug is corrected (see below) and we also added some corrections on the RECO/Fake contributions in order to enhance the PHASE2 endcaps representation.
Those corrections also correct the pbm such as in PoPtrueVsEta_pfx as we can see :
PR validation:
compilation is OK, basics tests (scram b runtests or local tests) are OK too.
runTheMatrix.py -l limited -i all --ibeos tests are fine (39 38 37 28 18 4 1 1 1 tests passed, 0 0 0 0 0 0 0 0 0 failed).
here is the run-log :
if this PR is a backport please specify the original PR and why you need to backport that PR:
Before submitting your pull requests, make sure you followed this checklist:
@beaudett
@SohamBhattacharya