[GCC11] Ignore used uninitialized warning in DTDigiSimLink

[smuzaffar]

Looks like the GCC 11 warning

  SimDataFormats/DigiSimLinks/src/DTDigiSimLink.cc:29:11: warning: 'result' is used uninitialized [-Wuninitialized]
    29 |   return *p_result;
      |           ^~~~~~~~
SimDataFormats/DigiSimLinks/src/DTDigiSimLink.cc:25:18: note: 'result' declared here
   25 |   ChannelPacking result;
      |                  ^~~~~~

is false positive. ThisPR proposes to ignore the used uninitialized warning for this selected code.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35114/25005

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• SimDataFormats/DigiSimLinks (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@sscruz, @fabiocos, @Fedespring, @battibass, @trocino, @apsallid, @abbiendi, @JanFSchulte, @jhgoh, @VinInn, @bsunanda, @HuguesBrun, @rovere, @lecriste, @calderona, @mmusich, @mtosi, @ebrondol, @cericeci this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e74ff/18231/summary.html
COMMIT: 77d014d
CMSSW: CMSSW_12_1_X_2021-09-01-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35114/18231/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 136.72413136.72413_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMININANO_data2016UL_HIPM_met+HARVESTDR2_REMININANO_data2016UL_HIPM_met/step2_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMININANO_data2016UL_HIPM_met+HARVESTDR2_REMININANO_data2016UL_HIPM_met.log

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000404
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3000370
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[srimanob]

Please test with #35121

[davidlange6]

hi @smuzaffar - do we understand exactly what reinterpret_cast does here (I don't..)? I think the intent was to reinterpret the two 16-bit unsigned ints as one 32-bit unsigned int. The examples I see suggest that instead the ChannelType* will point to ChannelPacking.wi.

[smuzaffar]

@davidlange6 , basically it is doing

return (static_cast<uint32_t>(theDigiNumber) << 16) | static_cast<uint32_t>(theWire);

I wanted to replace the whole function with the line above but it might be bit slower then the current implementation

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6e74ff/18247/summary.html
COMMIT: 77d014d
CMSSW: CMSSW_12_1_X_2021-09-01-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35114/18247/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000404
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000382
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[qliphy]

+1