Extend L1T CSC DQM with option for ME234/2 chambers and ME2/1 chamber at B904

[dildick]

PR description:

We are currently testing Run-3 trigger motherboard firmware for ME1/3 and MEX/2 chambers with Virtex-2 FPGAs, and for MEX/1 chambers with Virtex-6 FPGAs. We have an ME4/2 and ME2/1 chamber with full trigger+DAQ at B904 for this purpose. This PR extends the L1T CSC DQM with option for ME234/2 and MEX/1 chambers at B904 (follow-up of #33876). The results also hold for ME1/2 and ME1/3 because they share the same electronics setup (but do have different size and geometry).

Thanks to @barvic for helping with debugging, and to Karoly Banicz for taking the data.

PR validation:

Tested on the ME4/2 B904 chamber with a few thousand cosmic events.

CSC_dataVsEmul_B904_Cosmic_Run_210810_160642 (1).pdf

There should be no changes in the tests because the algorithm did not change, just the analysis code.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

FYI @tahuang1991

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35100/24986

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/CSCTriggerPrimitives/test/runCSCTriggerPrimitiveProducer_cfg.py modified in PR(s): Move CSC trigger and GEM-CSC trigger lookup tables into eventsetup objects (CCLUT-17) #34779

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

• DQM/L1TMonitor (dqm)
• DQM/L1TMonitorClient (dqm)
• IORawData/CSCCommissioning (daq)
• L1Trigger/CSCTriggerPrimitives (l1)

@andrius-k, @kmaeshima, @emeschi, @ErnestaP, @ahmad3213, @smorovic, @cmsbuild, @rekovic, @jfernan2, @cecilecaillol, @rvenditti can you please review it and eventually sign? Thanks.
@valuev, @ptcox, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[smorovic]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98ae8a/18185/summary.html
COMMIT: 5249a48
CMSSW: CMSSW_12_1_X_2021-08-31-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35100/18185/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000404
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3000370
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[smorovic]

+1

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35100/25008

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File L1Trigger/CSCTriggerPrimitives/test/runCSCTriggerPrimitiveProducer_cfg.py modified in PR(s): Move CSC trigger and GEM-CSC trigger lookup tables into eventsetup objects (CCLUT-17) #34779

[smorovic]

+1

[qliphy]

please test
last test was done some days ago.
@cms-sw/l1-l2 Please comment on this PR.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98ae8a/18532/summary.html
COMMIT: f7ceada
CMSSW: CMSSW_12_1_X_2021-09-11-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35100/18532/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2991 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3001001
• DQMHistoTests: Total failures: 7703
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2993276
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: found differences in 1 / 38 workflows

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

There are differences in the DD4Hep workflow 11634.911 comparisons: #35109

[qliphy]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98ae8a/18614/summary.html
COMMIT: f7ceada
CMSSW: CMSSW_12_1_X_2021-09-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35100/18614/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000833
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000805
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[qliphy]

+1