-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate CondTools-Ecal modules to use esconsumes #35079
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35079/24960
|
A new Pull Request was created by @sroychow (Suvankar Roy Chowdhury) for master. It involves the following packages:
@ggovi, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1623a0/18147/summary.html CMS StaticAnalyzer warnings: There are 3 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1623a0/18147/llvm-analysis/legacy-mod-sa.txt for details. Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migration in the package is not complete yet: still missing CondTools/Ecal/src/ESDBCopy.cc
Please also have a look at the static analyzer, which points out a large number of dead initializations or assignments. That should also get eventually fixed, (not necessarily in this PR) as those dead assignments may hide/witness possible real issues in the logic of the code.
This is done in #35149 . |
2c748c8
to
58ad57e
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35079/25217
|
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1623a0/18535/summary.html Comparison SummarySummary:
|
+db
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Part of #31061. Migrates modules of
CondTools/Ecal
to use esConsumes.PR validation:
Code compiles and scram checker doesn't show the EventSetup get warnings.
if this PR is a backport please specify the original PR and why you need to backport that PR:
NA.