-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize fields in ProcessCallGraph and HLTRegionalEcalResonanceFilter #35066
Conversation
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35066/24947
|
A new Pull Request was created by @mrodozov (Mircho Rodozov) for master. It involves the following packages:
@Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
-1 Failed Tests: Build ClangBuild BuildI found compilation error when building: from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-2300/src/HLTrigger/Timer/src/ProcessCallGraph.cc:14: /cvmfs/cms-ib.cern.ch/nweek-02695/slc7_amd64_gcc900/external/boost/1.75.0-dhcijl/include/boost/detail/iterator.hpp:13:1: note: #pragma message: This header is deprecated. Use instead. 13 | BOOST_HEADER_DEPRECATED("") | ^~~~~~~~~~~~~~~~~~~~~~~ /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-2300/src/HLTrigger/Timer/src/ProcessCallGraph.cc: In member function 'void ProcessCallGraph::preSourceConstruction(const edm::ModuleDescription&)': /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-2300/src/HLTrigger/Timer/src/ProcessCallGraph.cc:57:75: error: no match for 'operator=' (operand types are 'boost::adjacency_list, boost::property > >::vertex_bundled' {aka 'ProcessCallGraph::NodeType'} and '') 57 | graph_.m_graph[module.id()] = {module, edm::EDMModuleType::kSource, true}; | ^ In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-2300/src/HLTrigger/Timer/src/ProcessCallGraph.cc:30: /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-2300/src/HLTrigger/Timer/interface/ProcessCallGraph.h:29:10: note: candidate: 'ProcessCallGraph::NodeType& ProcessCallGraph::NodeType::operator=(const ProcessCallGraph::NodeType&)' 29 | struct NodeType { Clang BuildI found compilation error while trying to compile with clang. Command used:
Entering library rule at HLTrigger/Timer >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-2300/src/HLTrigger/Timer/src/ProcessCallGraph.cc >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-2300/src/HLTrigger/Timer/src/EDMModuleType.cc >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-2300/src/HLTrigger/Timer/src/memory_usage.cc >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-2300/src/HLTrigger/Timer/src/processor_model.cc /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-2300/src/HLTrigger/Timer/src/ProcessCallGraph.cc:57:31: error: no viable overloaded '=' graph_.m_graph[module.id()] = {module, edm::EDMModuleType::kSource, true}; ~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-27-2300/src/HLTrigger/Timer/interface/ProcessCallGraph.h:29:10: note: candidate function (the implicit move assignment operator) not viable: cannot convert initializer list argument to 'ProcessCallGraph::NodeType' struct NodeType { ^ |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35066/24948
|
Pull request #35066 was updated. @Martin-Grunewald can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2cb579/18125/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Fixes 2 of 3 issues on #35008
This is initializing two boolean fields - one is the nested
NodeType
structscheduled_
field,for which the default constructor is used to keep the fields untouched (instead of setting
scheduled_=false
)The other is
store5x5RecHitEB_
which follows in a state where ifif (doSelBarrel_)
is false,store5x5RecHitEB_
remains uninitialized and is later used here:https://github.com/cms-sw/cmssw/blob/master/HLTrigger/special/plugins/HLTRegionalEcalResonanceFilter.cc#L613
which is causing the error.
PR validation:
After the change the sanitizer doesn't complain (the logs aren't showing the errors)