-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTD reconstruction: replace specific forward layer with the general mother class #35062
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35062/24942
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages:
@kpedro88, @cmsbuild, @AdrianoDee, @srimanob, @slava77, @jpata can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7a5a9/18118/summary.html Comparison SummarySummary:
|
+reconstruction
|
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR is meant to address the issue #35036 as far as RecoMTD is concerned.
While introducing the new forward sector geometry for ETL, I overlooked the fact that the old ring double layer was explicitly invoked just to get the sign of the z coordinate within the
tryETLlayers
method. This can be generalized by casting the specific layer into the mother classForwardDetLayer
which is enough to get theBoundDisk
, and I expect this update should address the problem (to be verified).I took the opportunity to remove a few apparently unnecessary headers included.
PR validation:
Test wf 34634.0 does not show any difference in its DQM output.