-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make GenHIEventProducer edm::global #35052
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35052/24926
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages:
@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0bfe8d/18102/summary.html Comparison SummarySummary:
|
@cms-sw/generators-l2 Cold you please take a look? |
hi @makortel, same as in 35057 applies here, i wanted to run standalone check but had no time yet. by eye this looks good to me. let me know if you prefer a fast signature or a check on Monday. |
Monday is good enough, thanks! |
let me update: i had to move a bit things on my todo list but validation job is running now. will not be ready to sign before orp but should be done tomorrow morning. |
+generators |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
To make it support concurrent lumis (#25090).
PR validation:
Code compiles.