-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding protections to PATTriggerProducer when the path has zero filters: 12_1 #35043
Adding protections to PATTriggerProducer when the path has zero filters: 12_1 #35043
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35043/24906
|
A new Pull Request was created by @Sam-Harper (Sam Harper) for master. It involves the following packages:
@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7351d9/18086/summary.html Comparison SummarySummary:
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
As reported by @aescalante , PATTriggerProducer throws an out of bounds exception when run in " onlyStandAlone = cms.bool(False)" mode.
This is because there code assumes an HLT path will have at least one filter and has no protections for the case of a path having no filters. While this assumption seems reasonable, all HLT paths should have at least one filter (eg a prescale module) although personally I wouldnt assume this, in practice it fails as things like reconstruction_step and digi_step are also paths and have no filters
Therefore if PATTriggerProducer is run on data in full mode where the HLT was run together with other steps, it will fail. Note in production we use onlyStandAlone=True
This PR checks that a path has filters before accessing them.
No physics changes are expected, only changes is now workflows that crashed should now succeed.
PR validation:
Test config from Alberto now runs.