[GCC11] Fix warning: loop variable binds to temporary

[iarspider]

Log file: https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc11/CMSSW_12_1_X_2021-08-24-0900/Validation/CTPPS

.../Validation/CTPPS/plugins/CTPPSProtonReconstructionPlotter.cc: In constructor 'CTPPSProtonReconstructionPlotter::CTPPSProtonReconstructionPlotter(const edm::ParameterSet&)':
  .../Validation/CTPPS/plugins/CTPPSProtonReconstructionPlotter.cc:507:27: warning: loop variable 'sector' of type 'const string&' {aka 'const std::__cxx11::basic_string<char>&'} binds to a temporary constructed from type 'const char* const' [-Wrange-loop-construct]
   507 |   for (const std::string &sector : {"45", "56"}) {
      |                           ^~~~~~

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35041/24904

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• Validation/CTPPS (dqm)

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@jan-kaspar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[iarspider]

please test for slc7_amd64_gcc11

[cmsbuild]

-1

Failed Tests: UnitTests RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-712c8d/18080/summary.html
COMMIT: 8f390f0
CMSSW: CMSSW_12_1_X_2021-08-25-1100/slc7_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35041/18080/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @bsunanda Run3-gex90 Make unique material names as default for all Run3 scenarios #34983
• @bsunanda Run3-alca198 Modify the analyzers to record muons not on event basis but on single muon basis #34980
• @missirol Fixing some edge cases in HLT-Patatrack customisations #34992
• @dildick New option in CSC DigiToRaw to pack strip digis by CFEB in each chamber.  #34783
• @Dr15Jones Use sufficient digits when converting a double #34999

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-712c8d/18080/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-712c8d/18080/git-merge-result

Found compilation warnings

Unit Tests

I found errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS

RelVals

• 135.4

----- Begin Fatal Exception 27-Aug-2021 11:39:00 CEST-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
Unable to find plugin 'TrackingRecHitProducer' in category 'CMS EDM Framework Module'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

• 5.1

----- Begin Fatal Exception 27-Aug-2021 11:39:00 CEST-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
Unable to find plugin 'TrackingRecHitProducer' in category 'CMS EDM Framework Module'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

AddOn Tests

• fastsim

----- Begin Fatal Exception 27-Aug-2021 11:39:05 CEST-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
Unable to find plugin 'TrackingRecHitProducer' in category 'CMS EDM Framework Module'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

• fastsim1

----- Begin Fatal Exception 27-Aug-2021 11:39:05 CEST-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
Unable to find plugin 'TrackingRecHitProducer' in category 'CMS EDM Framework Module'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

• fastsim2

----- Begin Fatal Exception 27-Aug-2021 11:39:06 CEST-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
Unable to find plugin 'TrackingRecHitProducer' in category 'CMS EDM Framework Module'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

[iarspider]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-712c8d/18088/summary.html
COMMIT: 8f390f0
CMSSW: CMSSW_12_1_X_2021-08-26-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35041/18088/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 3000352
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3000330
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1