Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_0_X] Add HCAL tag HcalRespCorrs_2021_v3.0_mc to Run-3 MC GTs #34923

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Aug 17, 2021

PR description:

Please see description in #34922

Here is the list of differences:

The diffs are wrt the conditions in the master, and only show the differences in the requested tag, HcalRespCorrs_2021_v3.0_mc

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #34922

cc: @mseidel42 @abdoulline

Add HCAL tag HcalRespCorrs_2021_v3.0_mc
@cmsbuild cmsbuild added this to the CMSSW_12_0_X milestone Aug 17, 2021
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 17, 2021

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_12_0_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Aug 17, 2021

test parameters:

  • workflows = 7.23,159.0,11634.0,12434.0,12834.0

@tvami
Copy link
Contributor Author

tvami commented Aug 17, 2021

backport of #34922

@tvami
Copy link
Contributor Author

tvami commented Aug 17, 2021

@cmsbuild , please test

@abdoulline
Copy link

@tvami Thanks!

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e12615/17841/summary.html
COMMIT: 3972dac
CMSSW: CMSSW_12_0_X_2021-08-17-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34923/17841/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-e12615/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4154 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 440
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2998101
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: found differences in 3 / 38 workflows

@tvami
Copy link
Contributor Author

tvami commented Aug 18, 2021

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @tvami
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Aug 18, 2021
@tvami
Copy link
Contributor Author

tvami commented Aug 23, 2021

unhold

  • today's AlCa meeting concluded that we'd like this in this release

@cmsbuild cmsbuild removed the hold label Aug 23, 2021
@perrotta
Copy link
Contributor

unhold

  • today's AlCa meeting concluded that we'd like this in this releasebe

Good.
As soon as the master PR will be signed by AlCa, it can be merged there. After that, also merging the backport can be considered.

@francescobrivio
Copy link
Contributor

+alca

  • @perrotta @qliphy we can discuss tomorrow at the ORP about merging this PR for 12_0

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild cmsbuild removed the backport label Aug 23, 2021
@qliphy
Copy link
Contributor

qliphy commented Aug 25, 2021

+1

@cmsbuild cmsbuild merged commit 3e7c831 into cms-sw:CMSSW_12_0_X Aug 25, 2021
@francescobrivio
Copy link
Contributor

@qliphy didn't we decide at the ORP to wait for the validation before merging this PR?

@qliphy
Copy link
Contributor

qliphy commented Aug 25, 2021

@francescobrivio You are right. Indeed @perrotta also just reminded me on this.
Anyway we will build the 12_0_0 release next week once we get the green light, otherwise at worst this is easy to revert. We can discuss this at next Tuesday's ORP before making 12_0_0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants