-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate AlignmentProducer
to event consumes
#34885
migrate AlignmentProducer
to event consumes
#34885
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34885/24695
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7ae3bf/17797/summary.html Comparison SummarySummary:
|
tested successfully with this configuration file. |
+alca |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Title says it all, migrate
AlignmentProducer
to event consumes, as it is already done forAlignmentProducerAsAnalyzer.cc
cmssw/Alignment/CommonAlignmentProducer/plugins/AlignmentProducerAsAnalyzer.cc
Lines 21 to 25 in bd636b9
PR validation:
Run unit tests
scram b runtests
also usingAlignment/TrackerAlignment
package.if this PR is a backport please specify the original PR and why you need to backport that PR:
Will need to be backported to support HipPy alignment algorithm.