more Python3 fixes for geometry script

[kpedro88]

PR description:

Some branches of the script weren't explored in the unit tests, so some Python3 incompatibilities weren't previously noticed. They are fixed now.

PR validation:

Ran script successfully (no errors).

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34875/24678

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

• Configuration/Geometry (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @kpedro88, @cmsbuild, @AdrianoDee, @srimanob, @mdhildreth can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @slomeo, @vargasa this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

please test

[cmsbuild]

-1

Failed Tests: Build ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c049f5/17771/summary.html
COMMIT: 306ad3d
CMSSW: CMSSW_12_1_X_2021-08-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34875/17771/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @Dr15Jones Make header files in FWCore/Framework/interface consistent #34771
• @smuzaffar [SimCalorimetry] Avoid using private CondFormats/EcalObjects/src/classes.h #34849
• @smuzaffar Coderule script: fixes needed for python3 #34855
• @bsunanda Run3-gex87 Modify material budget code relevant to study XML vs DB #34856
• @bsunanda Run3-sim100 Take Vladimir's comments for include statements of CLHEP headers #34842
• @iarspider [GCC11] Fix warning: loop variable binds to a temporary #34852
• @Dr15Jones Performance improvements for DQM startup #34837
• @mmusich [RFC] add commissioning_run as DQM runType and use it in SiStrip online DQM client #34832
• @smuzaffar Replace boost::regex with std::regex #34826

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c049f5/17771/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c049f5/17771/git-merge-result

Build

I found compilation error when building:

>> Compiling  /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-12-2300/src/CondCore/Utilities/src/CondDBImport.cc
>> Compiling  /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-12-2300/src/CondCore/Utilities/src/CondDBTools.cc
>> Compiling  /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-12-2300/src/CondCore/Utilities/src/PayloadInspector.cc
>> Compiling  /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-12-2300/src/CondCore/Utilities/src/Utilities.cc
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-12-2300/src/CondCore/Utilities/src/CondDBTools.cc: In function 'size_t cond::persistency::importIovs(const string&, cond::persistency::Session&, const string&, cond::persistency::Session&, cond::Time_t, cond::Time_t, const string&, const string&, bool, bool, bool)':
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-12-2300/src/CondCore/Utilities/src/CondDBTools.cc:97:12: error: 'set' is not a member of 'std'
   97 |       std::set pids;
      |            ^~~
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-12-2300/src/CondCore/Utilities/src/CondDBTools.cc:4:1: note: 'std::set' is defined in header ''; did you forget to '#include '?
    3 | #include "CondCore/CondDB/interface/ConnectionPool.h"
  +++ |+#include 


Clang Build

I found compilation error while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 64 COMPILER='llvm compile'

>> Compiling  /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-12-2300/src/CondCore/Utilities/src/CondDBTools.cc
>> Compiling  /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-12-2300/src/CondCore/Utilities/src/PayloadInspector.cc
>> Compiling  /build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-12-2300/src/CondCore/Utilities/src/Utilities.cc
>> Building LCG reflex dict from header file src/CondCore/Utilities/src/classes.h
>> Compiling LCG dictionary: tmp/slc7_amd64_gcc900/src/CondCore/Utilities/src/CondCoreUtilities/a/CondCoreUtilities_xr.cc
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-12-2300/src/CondCore/Utilities/src/CondDBTools.cc:97:26: error: expected '(' for function-style cast or type construction
      std::set pids;
               ~~~~~~~~~~^
/build/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_12_1_X_2021-08-12-2300/src/CondCore/Utilities/src/CondDBTools.cc:97:12: error: no member named 'set' in namespace 'std'
      std::set pids;
      ~~~~~^


[kpedro88]

I'm going on vacation, somebody retest this when master isn't broken.

[smuzaffar]

please test

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c049f5/17776/summary.html
COMMIT: 306ad3d
CMSSW: CMSSW_12_1_X_2021-08-13-1700/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34875/17776/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test2021Geometry had ERRORS

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2999420
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2999397
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34875/24685

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #34875 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @kpedro88, @cmsbuild, @AdrianoDee, @srimanob, @mdhildreth can you please check and sign again.

[kpedro88]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c049f5/17782/summary.html
COMMIT: 57911e2
CMSSW: CMSSW_12_1_X_2021-08-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34875/17782/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2999420
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2999391
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[srimanob]

+Upgrade

Technical PR to fix python3 compatibility. PR test runs fine.

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1