Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPS Alignment - bug fix #34844

Merged
merged 5 commits into from
Aug 13, 2021
Merged

Conversation

MatiXOfficial
Copy link
Contributor

PR description:

Fixed a bug from #31728. Now, the PPSAlignmentConfig plugin is registered, and some necessary declarations were added.

Most likely, we will have to backport this update to 12_0.

PR validation:

Run the test from CalibPPS/AlignmentGlobal/tests and received expected results.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34844/24632

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @MatiXOfficial (Mateusz Kocot) for master.

It involves the following packages:

  • CondCore/CTPPSPlugins (db)
  • CondFormats/PPSObjects (alca)

@malbouis, @yuanchao, @cmsbuild, @tlampen, @ggovi, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@tocheng, @fabferro, @jan-kaspar, @mmusich, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34844/24636

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

Pull request #34844 was updated. @malbouis, @yuanchao, @cmsbuild, @tlampen, @ggovi, @pohsun, @francescobrivio, @tvami can you please check and sign again.

Copy link
Contributor

@francescobrivio francescobrivio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MatiXOfficial I suggest to also add this CondFormat to the several utility tools in CondCore/Utilites. You can have a look at https://github.com/cms-sw/cmssw/pull/29662/files to see which utilites might be useful.

@@ -87,6 +87,8 @@ struct Binning {

unsigned int n_bins_y_;
double y_min_, y_max_;

COND_SERIALIZABLE;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ggovi usually it is not allowed to change the a class in CondFormat, but this is a bugfix, is it ok?

@francescobrivio
Copy link
Contributor

type bugfix

@MatiXOfficial
Copy link
Contributor Author

@francescobrivio Thanks for the suggestion!

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34844/24642

  • This PR adds an extra 36KB to repository

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34844/24646

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

Pull request #34844 was updated. @malbouis, @yuanchao, @cmsbuild, @tlampen, @ggovi, @pohsun, @francescobrivio, @tvami can you please check and sign again.

@francescobrivio
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-922948/17741/summary.html
COMMIT: f2d90ce
CMSSW: CMSSW_12_1_X_2021-08-12-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34844/17741/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2999420
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2999397
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

+alca

@ggovi
Copy link
Contributor

ggovi commented Aug 13, 2021

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants