-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPS Alignment - bug fix #34844
PPS Alignment - bug fix #34844
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34844/24632
|
A new Pull Request was created by @MatiXOfficial (Mateusz Kocot) for master. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @tlampen, @ggovi, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34844/24636
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MatiXOfficial I suggest to also add this CondFormat
to the several utility tools in CondCore/Utilites
. You can have a look at https://github.com/cms-sw/cmssw/pull/29662/files to see which utilites might be useful.
@@ -87,6 +87,8 @@ struct Binning { | |||
|
|||
unsigned int n_bins_y_; | |||
double y_min_, y_max_; | |||
|
|||
COND_SERIALIZABLE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ggovi usually it is not allowed to change the a class in CondFormat, but this is a bugfix, is it ok?
type bugfix |
@francescobrivio Thanks for the suggestion! |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34844/24642
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34844/24646
|
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-922948/17741/summary.html Comparison SummarySummary:
|
+alca |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Fixed a bug from #31728. Now, the PPSAlignmentConfig plugin is registered, and some necessary declarations were added.
Most likely, we will have to backport this update to 12_0.
PR validation:
Run the test from CalibPPS/AlignmentGlobal/tests and received expected results.