GEM Validation update #34821

yeckang · 2021-08-09T12:36:27Z

PR description:

Change the directory path for the GEM Validation plots
Make a consistent naming scheme for GEM Validation plots with PR Updates on GEM onlineDQM due to the updates of DAQ dataformat, backport to CMSSW_11_3_X #34782
Use DQM plots with modeRelval option for release validation
Remove the duplicate plots of the GEM Validation and DQM
Small bugfix for plot naming

PR validation:

The branch has tested with the following commands to check if it works in 2 different geometry versions.

runTheMatrix.py -w upgrade -l 11611.0
runTheMatrix.py -w upgrade -l 35811.0

The code format has applied with scram-build code-format

… dqm plots)

…2 with cms-merge-topic

…ge-topic

cmsbuild · 2021-08-09T12:45:38Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34821/24584

This PR adds an extra 96KB to repository

cmsbuild · 2021-08-09T12:46:03Z

A new Pull Request was created by @yeckang (Yechan Kang) for master.

It involves the following packages:

DQM/GEM (dqm)
Validation/Configuration (dqm, simulation)
Validation/MuonGEMDigis (dqm)
Validation/MuonGEMHits (dqm)
Validation/MuonGEMRecHits (dqm)

@civanch, @kmaeshima, @andrius-k, @mdhildreth, @ErnestaP, @cmsbuild, @jfernan2, @ahmad3213, @rvenditti can you please review it and eventually sign? Thanks.
@rovere, @jshlee, @apsallid, @watson-ij, @lecriste, @ebrondol this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

civanch · 2021-08-09T14:55:25Z

please test

cmsbuild · 2021-08-09T17:34:03Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-488006/17646/summary.html
COMMIT: 74b0de3
CMSSW: CMSSW_12_1_X_2021-08-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34821/17646/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

23234.0

----- Begin Fatal Exception 09-Aug-2021 18:36:08 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'prevalidation_step2'
   [2] Calling method for module GEMDigiSource/'GEMDigiSource'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: MuonDigiCollection<GEMDetId,GEMDigi>
Looking for module label: muonGEMDigis
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

34634.0

----- Begin Fatal Exception 09-Aug-2021 18:41:16 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'prevalidation_step2'
   [2] Calling method for module GEMDigiSource/'GEMDigiSource'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: MuonDigiCollection<GEMDetId,GEMDigi>
Looking for module label: muonGEMDigis
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

28234.0

----- Begin Fatal Exception 09-Aug-2021 18:45:11 CEST-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'prevalidation_step2'
   [2] Calling method for module GEMDigiSource/'GEMDigiSource'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: MuonDigiCollection<GEMDetId,GEMDigi>
Looking for module label: muonGEMDigis
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

34834.999

RelVals-INPUT

11601.011601.0_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt10+2021+SingleElectronPt10_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11602.011602.0_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt35+2021+SingleElectronPt35_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log
11603.011603.0_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA/step2_SingleElectronPt1000+2021+SingleElectronPt1000_pythia8_GenSimINPUT+Digi+Reco+HARVEST+ALCA.log

Expand to see more relval errors ...

cmsbuild · 2021-08-13T08:42:25Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34821/24664

This PR adds an extra 20KB to repository

cmsbuild · 2021-08-13T08:42:49Z

Pull request #34821 was updated. @civanch, @kmaeshima, @andrius-k, @mdhildreth, @ErnestaP, @cmsbuild, @jfernan2, @ahmad3213, @rvenditti can you please check and sign again.

civanch · 2021-08-13T13:09:24Z

please test

cmsbuild · 2021-08-13T16:12:06Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-488006/17764/summary.html
COMMIT: ec592a3
CMSSW: CMSSW_12_1_X_2021-08-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34821/17764/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2996821
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2996792
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 140.977 KiB( 38 files compared)
DQMHistoSizes: changed ( 10024.0,... ): -11.746 KiB MuonGEMRecHitsV/GEMRecHitsTask
DQMHistoSizes: changed ( 10024.0,... ): 9.980 KiB GEM/RecHits
DQMHistoSizes: changed ( 10024.0,... ): 4.288 KiB GEM/Digis
DQMHistoSizes: changed ( 10024.0,... ): -1.461 KiB MuonGEMHitsV/GEMHitsTask
DQMHistoSizes: changed ( 10024.0,... ): 1.229 KiB GEM/SimHits
DQMHistoSizes: changed ( 10024.0,... ): -0.768 KiB MuonGEMDigisV/GEMDigisTask
DQMHistoSizes: changed ( 11634.0,... ): -15.338 KiB MuonGEMRecHitsV/GEMRecHitsTask
DQMHistoSizes: changed ( 11634.0,... ): 15.031 KiB GEM/RecHits
DQMHistoSizes: changed ( 11634.0,... ): -10.419 KiB MuonGEMDigisV/GEMDigisTask
DQMHistoSizes: changed ( 11634.0,... ): 8.576 KiB GEM/Digis
DQMHistoSizes: changed ( 11634.0 ): ...
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: found differences in 4 / 38 workflows

jfernan2 · 2021-08-13T16:20:11Z

Validation/MuonGEMDigis/plugins/GEMStripDigiValidation.cc

+        for (const auto& etaPart : superChamberVec[0]->chambers()[0]->etaPartitions()) {
+          Int_t ieta = etaPart->id().ieta();
+          ME3IdsKey key{region_id, station_id, ieta};
+          me_occ_pid_eta_[key] = bookPIDHist(booker, key2, ieta, "sim_occ_pid", "Particle population");


I am somehow confused by key*, shouldn't this booker have key as argument onstead of key2?

Usually we don't skip the layer part. But several plots are need to skip them.
In this reason, I made a special function for it to keep original form of the bookPIDHist.

jfernan2 · 2021-08-13T17:15:52Z

+1

civanch · 2021-08-14T14:55:37Z

+1

cmsbuild · 2021-08-14T14:55:58Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-08-15T02:21:23Z

+1

yeckang added 11 commits July 28, 2021 09:54

Changing the directory paths for the gem validation plots

7e5fc44

remove the subdirectories of gem validation

964d98c

reduce the size of gem validation plots (remove duplicated plots with…

7a1f80c

… dqm plots)

code-format

e42d61d

Merged GEM-onlineDQMForNewDAQStatus-12_0_0_pre3 from repository quark…

bf0ebae

…2 with cms-merge-topic

Merged gemValidation_12_0_0_pre3 from repository yeckang with cms-mer…

76cd776

…ge-topic

Bug fix in the naming of DQM plot

44e887e

GEMDQMForRelval added in gemSimValid

0bf9771

code-format

5ff6f04

Updating GEM Validation plots

1d26f7d

Reduced the number of the plots from GEM DQM (digi bx plots)

74b0de3

cmsbuild added this to the CMSSW_12_1_X milestone Aug 9, 2021

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures simulation-pending tests-pending labels Aug 9, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 9, 2021

yeckang changed the title ~~Gem valid 12 0 0 pre3~~ GEM Validation update Aug 9, 2021

cmsbuild added tests-started and removed tests-pending labels Aug 9, 2021

cmsbuild added tests-rejected and removed tests-started labels Aug 9, 2021

Merged gemValid_12_0_0_pre3 from repository yeckang with cms-merge-topic

71741f0

cmsbuild added code-checks-pending simulation-pending tests-pending and removed code-checks-approved labels Aug 13, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 13, 2021

cmsbuild added tests-started and removed tests-pending labels Aug 13, 2021

cmsbuild added tests-approved and removed tests-started labels Aug 13, 2021

jfernan2 reviewed Aug 13, 2021

View reviewed changes

cmsbuild added dqm-approved and removed dqm-pending labels Aug 13, 2021

cmsbuild added fully-signed simulation-approved and removed simulation-pending pending-signatures labels Aug 14, 2021

cmsbuild added orp-approved and removed orp-pending labels Aug 15, 2021

cmsbuild merged commit 913c7fe into cms-sw:master Aug 15, 2021

quark2 added a commit to quark2/cmssw that referenced this pull request Nov 28, 2021

Sync to the master; modifications on bx plots (see cms-sw#34821)

87361c3

quark2 mentioned this pull request Nov 28, 2021

Modification on r-phi distribution plots and fix on under/overflow bins in GEM onlineDQM, a backport to 12_0_X #36254

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GEM Validation update #34821

GEM Validation update #34821

yeckang commented Aug 9, 2021

cmsbuild commented Aug 9, 2021

cmsbuild commented Aug 9, 2021

civanch commented Aug 9, 2021

cmsbuild commented Aug 9, 2021

cmsbuild commented Aug 13, 2021

cmsbuild commented Aug 13, 2021

civanch commented Aug 13, 2021

cmsbuild commented Aug 13, 2021

jfernan2 Aug 13, 2021

yeckang Aug 13, 2021

jfernan2 commented Aug 13, 2021

civanch commented Aug 14, 2021

cmsbuild commented Aug 14, 2021

qliphy commented Aug 15, 2021

GEM Validation update #34821

GEM Validation update #34821

Conversation

yeckang commented Aug 9, 2021

PR description:

PR validation:

cmsbuild commented Aug 9, 2021

cmsbuild commented Aug 9, 2021

civanch commented Aug 9, 2021

cmsbuild commented Aug 9, 2021

RelVals

RelVals-INPUT

cmsbuild commented Aug 13, 2021

cmsbuild commented Aug 13, 2021

civanch commented Aug 13, 2021

cmsbuild commented Aug 13, 2021

Comparison Summary

jfernan2 Aug 13, 2021

Choose a reason for hiding this comment

yeckang Aug 13, 2021

Choose a reason for hiding this comment

jfernan2 commented Aug 13, 2021

civanch commented Aug 14, 2021

cmsbuild commented Aug 14, 2021

qliphy commented Aug 15, 2021